Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reduce usage of event.node.res #1513

Merged
merged 1 commit into from
Jul 31, 2023
Merged

refactor: reduce usage of event.node.res #1513

merged 1 commit into from
Jul 31, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jul 31, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Following up #1511, this reduces dependency on event.node.res across nitro codebase. event.handled checks are now removed too since send utility is expected to take care of it (in rare cases there might be regressions since send is async but we might investigate anything related in h3 send util if happens). Main part remaining are timing and cachedEventHandler to fully decouple from node.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #1513 (29ef47e) into main (2ecd9fa) will decrease coverage by 0.03%.
The diff coverage is 53.33%.

@@            Coverage Diff             @@
##             main    #1513      +/-   ##
==========================================
- Coverage   76.22%   76.19%   -0.03%     
==========================================
  Files          73       73              
  Lines        7456     7462       +6     
  Branches      732      731       -1     
==========================================
+ Hits         5683     5686       +3     
- Misses       1772     1774       +2     
- Partials        1        2       +1     
Files Changed Coverage Ξ”
src/dev/error.ts 21.81% <53.33%> (+11.61%) ⬆️

... and 1 file with indirect coverage changes

@pi0 pi0 merged commit e8e806a into main Jul 31, 2023
5 of 6 checks passed
@pi0 pi0 deleted the refactor/h3-node-res branch July 31, 2023 13:02
@pi0 pi0 mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant