update test

nitrojs · Nov 5, 2024 · ac18343 · ac18343
1 parent e57286d
commit ac18343
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 34 deletions.
diff --git a/test/fixture/plugins/vary.ts b/test/fixture/plugins/vary.ts
@@ -1,7 +1,10 @@
 export default defineNitroPlugin((app) => {
   app.hooks.hook("request", (event) => {
-    if (event.path.endsWith(".css")) setResponseHeader(event, "Vary", "Origin");
-    if (event.path.endsWith(".js"))
+    if (event.path.endsWith(".css")) {
+      setResponseHeader(event, "Vary", "Origin");
+    }
+    if (event.path.endsWith(".js")) {
       setResponseHeader(event, "Vary", ["Origin"]);
+    }
   });
 });
diff --git a/test/tests.ts b/test/tests.ts
@@ -311,38 +311,42 @@ export function testNitro(
     expect(data).toMatch("<h1 >Hello JSX!</h1>");
   });
 
-  it.skipIf(
-    ctx.preset.startsWith("cloudflare") || ctx.preset === "vercel-edge"
-  )("handles custom Vary header", async () => {
-    let headers = (
-      await callHandler({
-        url: "/foo.css",
-        headers: { "Accept-Encoding": "gzip" },
-      })
-    ).headers;
-    if (headers["vary"])
-      expect(
-        headers["vary"].includes("Origin") &&
-          headers["vary"].includes("Accept-Encoding")
-      ).toBeTruthy();
-
-    headers = (
-      await callHandler({ url: "/foo.css", headers: { "Accept-Encoding": "" } })
-    ).headers;
-    if (headers["vary"]) expect(headers["vary"]).toBe("Origin");
-
-    headers = (
-      await callHandler({
-        url: "/foo.js",
-        headers: { "Accept-Encoding": "gzip" },
-      })
-    ).headers;
-    if (headers["vary"])
-      expect(
-        headers["vary"].includes("Origin") &&
-          headers["vary"].includes("Accept-Encoding")
-      ).toBeTruthy();
-  });
+  it.runIf(ctx.nitro?.options.serveStatic)(
+    "handles custom Vary header",
+    async () => {
+      let headers = (
+        await callHandler({
+          url: "/foo.css",
+          headers: { "Accept-Encoding": "gzip" },
+        })
+      ).headers;
+      if (headers["vary"])
+        expect(
+          headers["vary"].includes("Origin") &&
+            headers["vary"].includes("Accept-Encoding")
+        ).toBeTruthy();
+
+      headers = (
+        await callHandler({
+          url: "/foo.css",
+          headers: { "Accept-Encoding": "" },
+        })
+      ).headers;
+      if (headers["vary"]) expect(headers["vary"]).toBe("Origin");
+
+      headers = (
+        await callHandler({
+          url: "/foo.js",
+          headers: { "Accept-Encoding": "gzip" },
+        })
+      ).headers;
+      if (headers["vary"])
+        expect(
+          headers["vary"].includes("Origin") &&
+            headers["vary"].includes("Accept-Encoding")
+        ).toBeTruthy();
+    }
+  );
 
   it("handles route rules - headers", async () => {
     const { headers } = await callHandler({ url: "/rules/headers" });