Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sports section #183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: sports section #183

wants to merge 1 commit into from

Conversation

heydoyouknowme0
Copy link
Contributor

  • fix: section pages runtime error
  • feat: sports section page

GetPsyched
GetPsyched requested changes May 15, 2024
View reviewed changes
app/[locale]/institute/sections/sports/page.tsx Outdated Show resolved Hide resolved
i18n/en.ts Outdated Show resolved Hide resolved
i18n/en.ts Outdated Show resolved Hide resolved
@heydoyouknowme0 heydoyouknowme0 changed the title feat/sports section feat: sports section May 16, 2024
GetPsyched
GetPsyched requested changes May 27, 2024
View reviewed changes
Copy link
Member

@GetPsyched GetPsyched left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML element ids need fixing (about us points to the main heading?) and add more headings to the navbar

@heydoyouknowme0
Copy link
Contributor Author

@GetPsyched About us is supposed to be just beneath the main heading, but db doesnt have that for now.
As for the headings thing all other topics are just subheadings, doesnt feel right to give them both the same precedence, also I'll have to add glyphs to all subheadings then too

@GetPsyched
Copy link
Member

Hmm, fair points. Will get back to this when merging

GetPsyched
GetPsyched reviewed Sep 26, 2024
View reviewed changes
Copy link
Member

@GetPsyched GetPsyched left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the deployment is failing. Did you remove the table or something? likely broken DB call

app/[locale]/institute/sections/sports/page.tsx
Comment on lines +282 to +287
<li
key={index}
dangerouslySetInnerHTML={{
__html: item,
}}
/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do this. Instead, initialise MDX to allow for markdown formatting. And convert any <strong> tags into **foo**.

@heydoyouknowme0
Copy link
Contributor Author

heydoyouknowme0 commented Sep 26, 2024 •
edited
Loading

Also, the deployment is failing. Did you remove the table or something? likely broken DB call

ya the db was wiped and sections table is empty rn
Edit: Working now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GetPsyched GetPsyched GetPsyched requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heydoyouknowme0 @GetPsyched