feat: added scroll aware navigation #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heydoyouknowme0
force-pushed
the
feat/scroll-aware-nav
branch
from
13cf9f7
to
542789c
Compare
GetPsyched
requested changes
May 4, 2024
heydoyouknowme0
force-pushed
the
feat/scroll-aware-nav
branch
from
542789c
to
3c9cd65
Compare
|
@GetPsyched shouldn't this be merged before the pages. |
|
It can be added retroactively. I've reviewed the PR and I'm not comfortable approving the changes across all pages just yet. It's fine if we keep this as a low priority until the pages are done. |
|
tbh I don't really like the implementation either, just don't know a better way |
|
Yeah. Let's draft this PR until we crunch through the rest and we can get back to this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problems: current implementation functions on change of the divs visibility so if a div is never out of visible area, even if the prominent divs goes out of the area it doesnt revert to the first state.
have to limit intersection range
fixed: should work as intended in most devices