Fix linestring splitting issues #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specific case added as a test was triggering the condition where pE != pN but pE.length() == pN.length() and falling through to the "Unexpected points..." error. If we consistently check lengths through all of these cases, this is fixed.
Should be more robust to numerical edge cases (0/inf/nan) and under/overflow.
Issue 53 was failing with an unreasonably precise comparison of values (point, gridline) near zero. Fixed by including the grid cell size as part of the calculation of a reasonably scaled epsilon, in general the utility almost_equals now also takes an argument for an indicative order-of-magnitude reference value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #53 and #61