Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index page ui improvementation #121

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

akaashvaa
Copy link

let me know if i missed something.

Copy link
Owner

@nishantwrp nishantwrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @akaashvaa, look pretty awesome. I'll prioritize reviewing it this week.

Copy link
Collaborator

@beingnoble03 beingnoble03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akaashvaa for this. Looks like a really good improvement over the old UI. Would lean on @nishantwrp for further review.

A little worried about the mobile view for sidebar. I think this can be moved to left side of the screen with a margin of 10px like earlier. Maybe, also retain the sliding animation.
image

Comment on lines 223 to 226
style={{
margin: "2rem 0",
textAlign: "center",
}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be defined in index.css.

Comment on lines 1 to 8
:root {
--background: rgba(255, 255, 255, 1);
--card: rgba(237, 237, 237, 1);
--primary: rgba(247, 247, 247, 0.9);
--primary-foreground: rgba(240, 240, 240, 1);
--secondary: rgba(127, 127, 127, 1);
--secondary-foreground: rgba(237, 237, 237, 1);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Looks neat.

Copy link
Author

@akaashvaa akaashvaa Jul 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screencast.from.07-07-24.07.25.58.PM.IST.webm

Checkpoint

  • moved sidebar to the left of the screen along with animation
  • moved style attribute property to index.css

changes

  • GSOC Organization logo added
  • added a button for scroll to the top ( bottom right corner )
  • total no of result (style changed)
  • card styles chnaged
    • tried to put the technology container at the bottom

let me know if anything else i missed after then i will commit the changes.


i also want to add some feature :

  1. how about adding the style lint to orgainise the css baised on the order of their property or alphabetically
  2. apply lazy loading for performance
    if u agree then i happy to create an issue on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants