Refactor dyn hooks 1.10 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anushkamittal2001 <[email protected]> Minor correction in comparison Signed-off-by: anushkamittal2001 <[email protected]> Changes in mutatingWebhookConfiguration Signed-off-by: anushkamittal2001 <[email protected]> Add minor change in variable declaration Signed-off-by: anushkamittal2001 <[email protected]> Correct comparison in controller.go Signed-off-by: anushkamittal2001 <[email protected]>
Signed-off-by: anushkamittal2001 <[email protected]>
anushkamittal2001
requested review from
eddycharly and
realshuting
as code owners
Signed-off-by: anushkamittal2001 <[email protected]>
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## release-1.10-n4k #56 +/- ##
====================================================
+ Coverage 34.63% 34.67% +0.04%
====================================================
Files 223 223
Lines 21426 21523 +97
====================================================
+ Hits 7420 7463 +43
- Misses 13255 13300 +45
- Partials 751 760 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: anushkamittal2001 <[email protected]>
Signed-off-by: anushkamittal2001 <[email protected]>
pns-nirmata
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Changes for dynamic webhook configuration
upstream Kyverno PR