Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dummy PR to trigger CI for N4K 1.10 #44

Closed
wants to merge 11 commits into from

Conversation

pns-nirmata
Copy link

Explanation

Dummy PR to trigger tests.

@pns-nirmata pns-nirmata marked this pull request as draft September 14, 2023 16:04
@pns-nirmata pns-nirmata requested review from realshuting and removed request for realshuting September 14, 2023 16:04
@pns-nirmata pns-nirmata changed the title Release 1.10 n4k perf opt Release 1.10 n4k performance optimizations Sep 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Merging #44 (faa36ca) into release-1.10-n4k (99fbd33) will decrease coverage by 0.08%.
The diff coverage is 40.23%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@                 Coverage Diff                  @@
##           release-1.10-n4k      #44      +/-   ##
====================================================
- Coverage             34.61%   34.54%   -0.08%     
====================================================
  Files                   222      223       +1     
  Lines                 21367    21481     +114     
====================================================
+ Hits                   7396     7420      +24     
- Misses                13222    13310      +88     
- Partials                749      751       +2     
Files Changed Coverage Δ
pkg/controllers/webhook/controller.go 0.00% <0.00%> (ø)
pkg/engine/context/mock_context.go 0.00% <0.00%> (ø)
pkg/engine/jsonutils/convert.go 0.00% <0.00%> (ø)
pkg/engine/utils/foreach.go 0.00% <0.00%> (ø)
pkg/engine/utils/utils.go 0.00% <0.00%> (ø)
pkg/validation/policy/validate.go 52.94% <ø> (ø)
pkg/engine/jmespath/interface.go 33.33% <33.33%> (+33.33%) ⬆️
pkg/engine/context/context.go 44.22% <50.00%> (-1.81%) ⬇️
pkg/engine/jmespath/new.go 69.56% <63.15%> (-30.44%) ⬇️
pkg/engine/context/utils.go 57.89% <65.71%> (+19.65%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pns-nirmata and others added 3 commits September 14, 2023 22:57
Signed-off-by: anushkamittal2001 <[email protected]>

Minor correction in comparison

Signed-off-by: anushkamittal2001 <[email protected]>

Changes in mutatingWebhookConfiguration

Signed-off-by: anushkamittal2001 <[email protected]>

Add minor change in variable declaration

Signed-off-by: anushkamittal2001 <[email protected]>

Correct comparison in controller.go

Signed-off-by: anushkamittal2001 <[email protected]>
[1.10-ebay] Configure webhooks dynamically
@pns-nirmata pns-nirmata changed the title Release 1.10 n4k performance optimizations Dummy PR to trigger CI for N4K 1.10 Sep 14, 2023
@pns-nirmata
Copy link
Author

Close dummy PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants