Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Enable SPM voxel-based FDR #3558

Merged
merged 2 commits into from
May 17, 2023
Merged

Conversation

mmbannert
Copy link
Contributor

Hi,

The SPM interface currently does not support voxel-based FDR. The MATLAB version of SPM readily provides this functionality, however, if you change your SPM defaults accordingly. There is no easy way to achieve this in nipype. I believe that FDR is a very useful way of correcting for multiple comparisons when analyzing fMRI data. Other users share this view because a similar PR has already been made by Lorenzo here. The changes proposed in my PR are minimally invasive and thus are very unlikely to cause any problems with respect to backward compatibility.

List of changes proposed in this PR (pull-request)

  • Added a single new binary (Boolean) input for whether or not the user wants to use voxel-based FDR.
  • Default is False.
  • ThresholdInputSpecs checks if the input for this parameter contradicts the input made for FWE because you cannot have both FWE and voxel-based FDR correction.
  • If conflicting inputs are found, it raises a ValueError.

I hope you will find these changes useful as well.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks backwards-compatible, so if it works for you, I have no objections.

@effigies effigies merged commit 20ed59a into nipy:master May 17, 2023
@effigies effigies mentioned this pull request Mar 20, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants