Hex encode the data field of the online transaction #2993
Conversation
pow-migration/src/monitor.rs
Outdated
| @@ -72,7 +72,7 @@ pub fn generate_online_tx(validator: String) -> OutgoingTransaction { | |||
| to: Address::burn_address().to_user_friendly_address(), | |||
| value: 1, //Lunas | |||
| fee: 0, | |||
| data: Some("online".to_string()), | |||
| data: Some(Blake2bHash::default().to_hex()), | |||
There was a problem hiding this comment.
Default hash is 64 0s long. A lot of unnecessary data. You can get the utf8 bytes of a string with "online".bytes(), which you can then put as the data.
There was a problem hiding this comment.
I thought about keep using "online" but then realized that later in the process what we are doing is sending a hash (genesis hash), so I thought it was ok to send the default hash as an indication of "we have not computed a hash yet"
But since we are not doing anything useful with this field, I guess "online" or anything is fine
There was a problem hiding this comment.
The 0-hash is actually still a valid genesis block hash :D
|
What's the motivation for changing it from |
The data field of the online transactions needs to be a hex encoded string
viquezclaudio
force-pushed
the
viquezcl/pow-migration-fix
branch
from
aff3b0c
to
a383ff8
Compare
viquezclaudio
changed the title
| @@ -132,7 +132,7 @@ fn is_valid_ready_txn( | |||
| /// Checks if the provided transaction meets the criteria in order to be | |||
| /// considered a valid online-transaction | |||
| fn is_valid_online_txn(txn: &TransactionDetails, block_window: &Range<u32>) -> bool { | |||
| Some("online".to_string()) == txn.data | |||
| Some(hex::encode(String::from("online"))) == txn.data | |||
There was a problem hiding this comment.
Um guessing this is optimized by the compiler for being static?
There was a problem hiding this comment.
It's not, but it also doesn't really matter.
| Some(hex::encode(String::from("online"))) == txn.data | |
| Some(hex::encode("online")) == txn.data |
| Some(hex::encode(String::from("online"))) == txn.data | |
| txn.data.as_ref().is_some_and(|hex| hex == "6f6e6c696e65") // "online" |
When a validator is reporting as online before the activation process, no genesis has been computed yet, so we use the default hash (0s) as part of the data field.
...
This fixes #___.
Pull request checklist
clippyandrustfmtwarnings.