Fix DoubleProposalProofs
#2983
Fix DoubleProposalProofs
#2983
Conversation
| @@ -405,13 +419,27 @@ impl DoubleProposalProof { | |||
|
|
|||
| if self.header1.block_number != self.header2.block_number | |||
| || self.header1.round != self.header2.round | |||
There was a problem hiding this comment.
Is this check still correct or should it go away?
There was a problem hiding this comment.
I would say this was not correct before and it should be removed. The round in the header only denotes when a proposal was created, not when it was proposed. Thus it should not be checked here.
| mut justification1: SchnorrSignature, | ||
| mut header2: MacroHeader, | ||
| mut round2: u32, | ||
| mut valid_round2: Option<u32>, |
There was a problem hiding this comment.
Should I merge the two round parameters into one, given that they have to be the same?
There was a problem hiding this comment.
I would prefer these be TendermintProposal, making the signature much smaller. If that turns out to be annoying or to require unnecessary cloning, then I think one round could be removed yes.
| header1: MacroHeader, | ||
| /// Header number 2. | ||
| header2: MacroHeader, | ||
| round1: u32, | ||
| round2: u32, | ||
| valid_round1: Option<u32>, | ||
| valid_round2: Option<u32>, |
There was a problem hiding this comment.
I would prefer
| header1: MacroHeader, | |
| /// Header number 2. | |
| header2: MacroHeader, | |
| round1: u32, | |
| round2: u32, | |
| valid_round1: Option<u32>, | |
| valid_round2: Option<u32>, | |
| proposal1: TendermintProposal, | |
| /// Proposal number 2. | |
| proposal2: TendermintProposal, |
| mut justification1: SchnorrSignature, | ||
| mut header2: MacroHeader, | ||
| mut round2: u32, | ||
| mut valid_round2: Option<u32>, |
There was a problem hiding this comment.
I would prefer these be TendermintProposal, making the signature much smaller. If that turns out to be annoying or to require unnecessary cloning, then I think one round could be removed yes.
| @@ -405,13 +419,27 @@ impl DoubleProposalProof { | |||
|
|
|||
| if self.header1.block_number != self.header2.block_number | |||
| || self.header1.round != self.header2.round | |||
There was a problem hiding this comment.
I would say this was not correct before and it should be removed. The round in the header only denotes when a proposal was created, not when it was proposed. Thus it should not be checked here.
hrxi
force-pushed
the
hrxi/double_proposal_proof
branch
3 times, most recently
from
263c16e
to
117207b
Compare
They required data unrelated to the signed proposals. It now uses the same signing infrastructure by factoring it out to `TendermintProposal` in a common crate. Fixes #2981.
The round in the proposal message is the relevant one.
hrxi
force-pushed
the
hrxi/double_proposal_proof
branch
from
117207b
to
4f21297
Compare
They required data unrelated to the signed proposals. It now uses the same signing infrastructure by factoring it out to
TendermintProposalin a common crate.Fixes #2981.