network-libp2p: Migrate AutoNAT v1 protocol to v2 #2955
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Transition from AutoNAT v1 protocol to v2
Main differences:
autonat v1
allowed testing reachability for the node.autonat v2
allows testing reachability for an individual address.autonat v2
provides a mechanism for nodes to verify whether the peer actually successfully dialled an address.autonat v2
provides a mechanism for nodes to dial an IP address different from the requesting node's observed IP address without risking amplification attacks.autonat v1
disallowed such dials to prevent amplification attacks.This PR should contribute improving the issues stated by #276
Pull request checklist
clippy
andrustfmt
warnings.