network-libp2p: Migrate AutoNAT v1 protocol to v2 #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Eligioo
added
the
testnet-restart
Eligioo
force-pushed
the
stefan/autonat2
branch
from
fb4086d
to
82e95d9
Compare
nibhar
approved these changes
Oct 8, 2024
Eligioo
force-pushed
the
stefan/autonat2
branch
from
82e95d9
to
bb1d23b
Compare
jsdanielh
reviewed
Oct 9, 2024
Eligioo
force-pushed
the
stefan/autonat2
branch
5 times, most recently
from
e55ea8a
to
bebe898
Compare
Eligioo
force-pushed
the
stefan/autonat2
branch
from
bebe898
to
efe8c95
Compare
jsdanielh
approved these changes
Oct 10, 2024
The AutoNAT V2 behaviour no longer has this config option
jsdanielh
force-pushed
the
stefan/autonat2
branch
from
efe8c95
to
4d07918
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Transition from AutoNAT v1 protocol to v2
Main differences:
autonat v1allowed testing reachability for the node.autonat v2allows testing reachability for an individual address.autonat v2provides a mechanism for nodes to verify whether the peer actually successfully dialled an address.autonat v2provides a mechanism for nodes to dial an IP address different from the requesting node's observed IP address without risking amplification attacks.autonat v1disallowed such dials to prevent amplification attacks.This PR should contribute improving the issues stated by #276
Pull request checklist
clippyandrustfmtwarnings.