network-libp2p: Cleanup, fix and remove ToDos from the discovery behaviour #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…viour Cleanup, fix and remove ToDos from the discovery behaviour: - Fix the update the `own_peer_contact`. - Make sure that the `own_peer_contact` never gets to the `peer_contacts`. - Only update peer contacts if the timestamp is greater than ours and do not allow future timestamps. - Remove the unused clock argument from the behaviour and the network. - Make sure that the key of the peer contact matches the `PeerId` of the connection. - Remove the unused `user_agent` from the `DiscoveryMessage` message in the discovery protocol.
jsdanielh
force-pushed
the
jsdanielh/network4
branch
from
b2f50c3
to
22e218a
Compare
viquezclaudio
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup, fix and remove ToDos from the discovery behaviour:
own_peer_contact.own_peer_contactnever gets to thepeer_contacts.PeerIdof the connection.user_agentfrom theDiscoveryMessagemessage in the discovery protocol.Pull request checklist
clippyandrustfmtwarnings.