network-libp2p: Expose a configuration for the desired number of peers #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdanielh
force-pushed
the
jsdanielh/network3
branch
from
ec0e777
to
1af0b21
Compare
jsdanielh
force-pushed
the
jsdanielh/network3
branch
2 times, most recently
from
9b75335
to
1af0b21
Compare
jsdanielh
force-pushed
the
jsdanielh/network3
branch
3 times, most recently
from
2808b17
to
4bd5759
Compare
hrxi
reviewed
Jan 25, 2024
jsdanielh
force-pushed
the
jsdanielh/network3
branch
from
4bd5759
to
45b97e5
Compare
Expose a configuration for the desired number of peers for the connection pool to realize when to try to connect to more peers. This configuration is exposed in the network and is set in the client to be `consensus.min_peers`.
Make the `ConnectionState` aware of the desired number of connections such that when doing `housekeeping` it resets the connections marked as down after 1s when the number of connections is below the desired number. This changes how eagerly connections are re-tried when the number of connected peers is less than the desired value.
jsdanielh
force-pushed
the
jsdanielh/network3
branch
from
45b97e5
to
1d388bc
Compare
sisou
reviewed
Mar 4, 2024
| @@ -297,6 +297,7 @@ impl ClientInner { | |||
| false, | |||
| required_services, | |||
| tls_config, | |||
| config.consensus.min_peers, | |||
There was a problem hiding this comment.
Should this not pass in the desired peer count?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consensus.min_peers.ConnectionStateaware of the desired number of connections such that when doinghousekeepingit resets the connections marked as down after 1s when the number of connections is below the desired number. This changes how eagerly connections are re-tried when the number of connected peers is less than the desired value.Pull request checklist
clippyandrustfmtwarnings.