Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double proposal proof signature verification generates the wrong data to be signed #2981

Open
hrxi opened this issue Oct 16, 2024 · 0 comments · May be fixed by #2983
Open

Double proposal proof signature verification generates the wrong data to be signed #2981

hrxi opened this issue Oct 16, 2024 · 0 comments · May be fixed by #2983
Assignees

Comments

@hrxi
Copy link
Member

hrxi commented Oct 16, 2024

This means that it's essentially impossible to generate double proposal proofs currently.

Currently, the double proposal proofs simply sign the Blake2b hash of the macro header, but the correct data can be seen in the following:

fn sign_proposal(
&self,
proposal_message: &ProposalMessage<Self::Proposal>,
) -> Self::ProposalSignature {
let data = SignedProposal::hash(
&proposal_message.proposal.0,
proposal_message.round,
proposal_message.valid_round,
)
.serialize_to_vec();
(
self.block_producer.signing_key.sign(&data),
self.validator_slot_band,
)
}

@hrxi hrxi self-assigned this Oct 16, 2024
hrxi added a commit that referenced this issue Oct 17, 2024
They required data unrelated to the signed proposals. It now uses the
same signing infrastructure by factoring it out to `TendermintProposal`
in a common crate.

Fixes #2981.
hrxi added a commit that referenced this issue Oct 17, 2024
They required data unrelated to the signed proposals. It now uses the
same signing infrastructure by factoring it out to `TendermintProposal`
in a common crate.

Fixes #2981.
@hrxi hrxi linked a pull request Oct 17, 2024 that will close this issue
hrxi added a commit that referenced this issue Oct 18, 2024
They required data unrelated to the signed proposals. It now uses the
same signing infrastructure by factoring it out to `TendermintProposal`
in a common crate.

Fixes #2981.
hrxi added a commit that referenced this issue Oct 21, 2024
They required data unrelated to the signed proposals. It now uses the
same signing infrastructure by factoring it out to `TendermintProposal`
in a common crate.

Fixes #2981.
hrxi added a commit that referenced this issue Oct 23, 2024
They required data unrelated to the signed proposals. It now uses the
same signing infrastructure by factoring it out to `TendermintProposal`
in a common crate.

Fixes #2981.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant