-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double proposal proof signature verification generates the wrong data to be signed #2981
Comments
hrxi
added a commit
that referenced
this issue
Oct 17, 2024
They required data unrelated to the signed proposals. It now uses the same signing infrastructure by factoring it out to `TendermintProposal` in a common crate. Fixes #2981.
hrxi
added a commit
that referenced
this issue
Oct 17, 2024
They required data unrelated to the signed proposals. It now uses the same signing infrastructure by factoring it out to `TendermintProposal` in a common crate. Fixes #2981.
hrxi
added a commit
that referenced
this issue
Oct 18, 2024
They required data unrelated to the signed proposals. It now uses the same signing infrastructure by factoring it out to `TendermintProposal` in a common crate. Fixes #2981.
hrxi
added a commit
that referenced
this issue
Oct 21, 2024
They required data unrelated to the signed proposals. It now uses the same signing infrastructure by factoring it out to `TendermintProposal` in a common crate. Fixes #2981.
hrxi
added a commit
that referenced
this issue
Oct 23, 2024
They required data unrelated to the signed proposals. It now uses the same signing infrastructure by factoring it out to `TendermintProposal` in a common crate. Fixes #2981.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This means that it's essentially impossible to generate double proposal proofs currently.
Currently, the double proposal proofs simply sign the Blake2b hash of the macro header, but the correct data can be seen in the following:
core-rs-albatross/validator/src/tendermint.rs
Lines 364 to 378 in 76cc30b
The text was updated successfully, but these errors were encountered: