Skip to content

Porting MuSig2 to core-rs-albatross #11042

Porting MuSig2 to core-rs-albatross

Porting MuSig2 to core-rs-albatross #11042

Triggered via pull request December 19, 2023 15:17
Status Failure
Total duration 33m 7s
Artifacts 1

build+test.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 error and 17 warnings
rustfmt
Process completed with exit code 1.
this expression creates a reference which is immediately dereferenced by the compiler: wallet/src/multisig_account.rs#L141
warning: this expression creates a reference which is immediately dereferenced by the compiler --> wallet/src/multisig_account.rs:141:17 | 141 | &aggregated_public_key, | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregated_public_key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: wallet/src/multisig_account.rs#L119
warning: this expression creates a reference which is immediately dereferenced by the compiler --> wallet/src/multisig_account.rs:119:13 | 119 | &commitments_data, | ^^^^^^^^^^^^^^^^^ help: change this to: `commitments_data` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: wallet/src/multisig_account.rs#L109
warning: this expression creates a reference which is immediately dereferenced by the compiler --> wallet/src/multisig_account.rs:109:65 | 109 | PublicKey::from(DelinearizedPublicKey::sum_delinearized(&public_keys)) | ^^^^^^^^^^^^ help: change this to: `public_keys` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
useless conversion to the same type: `nimiq_keys::PublicKey`: wallet/src/multisig_account.rs#L109
warning: useless conversion to the same type: `nimiq_keys::PublicKey` --> wallet/src/multisig_account.rs:109:9 | 109 | PublicKey::from(DelinearizedPublicKey::sum_delinearized(&public_keys)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PublicKey::from()`: `DelinearizedPublicKey::sum_delinearized(&public_keys)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
the loop variable `i` is used to index `nonces`: keys/src/multisig/mod.rs#L230
warning: the loop variable `i` is used to index `nonces` --> keys/src/multisig/mod.rs:230:18 | 230 | for i in 1..MUSIG2_PARAMETER_V { | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator and enumerate() | 230 | for (i, <item>) in nonces.iter().enumerate().take(MUSIG2_PARAMETER_V).skip(1) { | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
the loop variable `i` is used to index `partial_agg_commitments`: keys/src/multisig/mod.rs#L178
warning: the loop variable `i` is used to index `partial_agg_commitments` --> keys/src/multisig/mod.rs:178:18 | 178 | for i in 1..MUSIG2_PARAMETER_V { | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator and enumerate() | 178 | for (i, <item>) in partial_agg_commitments.iter().enumerate().take(MUSIG2_PARAMETER_V).skip(1) { | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
the loop variable `i` is only used to index `partial_agg_commitments`: keys/src/multisig/mod.rs#L168
warning: the loop variable `i` is only used to index `partial_agg_commitments` --> keys/src/multisig/mod.rs:168:18 | 168 | for i in 0..MUSIG2_PARAMETER_V { | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator | 168 | for <item> in partial_agg_commitments.iter().take(MUSIG2_PARAMETER_V) { | ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
useless conversion to the same type: `public_key::PublicKey`: keys/src/multisig/mod.rs#L149
warning: useless conversion to the same type: `public_key::PublicKey` --> keys/src/multisig/mod.rs:149:36 | 149 | let aggregate_public_key = PublicKey::from(DelinearizedPublicKey::sum_delinearized( | ____________________________________^ 150 | | &self.all_public_keys, 151 | | )); | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default help: consider removing `PublicKey::from()` | 149 ~ let aggregate_public_key = DelinearizedPublicKey::sum_delinearized( 150 + &self.all_public_keys, 151 ~ ); |
the loop variable `i` is only used to index `own_commitments`: keys/src/multisig/mod.rs#L100
warning: the loop variable `i` is only used to index `own_commitments` --> keys/src/multisig/mod.rs:100:18 | 100 | for i in 0..MUSIG2_PARAMETER_V { | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop = note: `#[warn(clippy::needless_range_loop)]` on by default help: consider using an iterator | 100 | for <item> in own_commitments.iter().take(MUSIG2_PARAMETER_V) { | ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using `clone` on type `[u8; 32]` which implements the `Copy` trait: keys/src/multisig/public_key.rs#L25
warning: using `clone` on type `[u8; 32]` which implements the `Copy` trait --> keys/src/multisig/public_key.rs:25:36 | 25 | let p = CompressedEdwardsY(pk_bytes.clone()).decompress().unwrap(); | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*pk_bytes` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default
the loop variable `i` is used to index `nonces`: keys/src/multisig/mod.rs#L230
warning: the loop variable `i` is used to index `nonces` --> keys/src/multisig/mod.rs:230:18 | 230 | for i in 1..MUSIG2_PARAMETER_V { | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator and enumerate() | 230 | for (i, <item>) in nonces.iter().enumerate().take(MUSIG2_PARAMETER_V).skip(1) { | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
the loop variable `i` is used to index `partial_agg_commitments`: keys/src/multisig/mod.rs#L178
warning: the loop variable `i` is used to index `partial_agg_commitments` --> keys/src/multisig/mod.rs:178:18 | 178 | for i in 1..MUSIG2_PARAMETER_V { | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator and enumerate() | 178 | for (i, <item>) in partial_agg_commitments.iter().enumerate().take(MUSIG2_PARAMETER_V).skip(1) { | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
the loop variable `i` is only used to index `partial_agg_commitments`: keys/src/multisig/mod.rs#L168
warning: the loop variable `i` is only used to index `partial_agg_commitments` --> keys/src/multisig/mod.rs:168:18 | 168 | for i in 0..MUSIG2_PARAMETER_V { | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator | 168 | for <item> in partial_agg_commitments.iter().take(MUSIG2_PARAMETER_V) { | ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
useless conversion to the same type: `public_key::PublicKey`: keys/src/multisig/mod.rs#L149
warning: useless conversion to the same type: `public_key::PublicKey` --> keys/src/multisig/mod.rs:149:36 | 149 | let aggregate_public_key = PublicKey::from(DelinearizedPublicKey::sum_delinearized( | ____________________________________^ 150 | | &self.all_public_keys, 151 | | )); | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default help: consider removing `PublicKey::from()` | 149 ~ let aggregate_public_key = DelinearizedPublicKey::sum_delinearized( 150 + &self.all_public_keys, 151 ~ ); |
the loop variable `i` is only used to index `own_commitments`: keys/src/multisig/mod.rs#L100
warning: the loop variable `i` is only used to index `own_commitments` --> keys/src/multisig/mod.rs:100:18 | 100 | for i in 0..MUSIG2_PARAMETER_V { | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop = note: `#[warn(clippy::needless_range_loop)]` on by default help: consider using an iterator | 100 | for <item> in own_commitments.iter().take(MUSIG2_PARAMETER_V) { | ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using `clone` on type `[u8; 32]` which implements the `Copy` trait: keys/src/multisig/public_key.rs#L25
warning: using `clone` on type `[u8; 32]` which implements the `Copy` trait --> keys/src/multisig/public_key.rs:25:36 | 25 | let p = CompressedEdwardsY(pk_bytes.clone()).decompress().unwrap(); | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*pk_bytes` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Artifacts

Produced during runtime
Name Size
reconnect-test-logs Expired
2.3 MB