Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
a: BigInt
is zero if and only ifa.limbs
is empty. This simplifiesisZero
and reduces special cases to consider when consuming aBigInt
.While checking that all functions uphold this invariant, I noticed that
shl
andshr
were buggy:shl
didn't check for zero, which allowed the user to constructBigInt
s with arbitrarily many zeros in its limbs, breaking an invariantshr
didn't check if the shift is too big, which could result in an exception