Add head function #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
reviewed
Aug 9, 2018
|
|
||
| /** | ||
| * @expectedException \InvalidArgumentException | ||
| * @expectedExceptionMessage Argument must be non-empty |
There was a problem hiding this comment.
How about using
$this->expectException(\InvalidArgumentException::class);
$this->expectExceptionMessage('Argument must be non-empty');instead?
Also see https://thephp.cc/news/2016/02/questioning-phpunit-best-practices.
There was a problem hiding this comment.
Makes sense, but it would be inconsistent with the other test cases since they all use annotations. Personally I'd prefer consistency and address this issue separately.
1 task
danizord
approved these changes
Aug 9, 2018
|
@nikic any thoughts on adding this function? |
|
I know this is quite old but the code seems still good. Will it be merged ? Also good idea the head but to match the bash one for example would it be possible to add a number of rows to return ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be nice to have a function that fetches the head of an iterable and throws an exception if it's non-empty instead of having to call the
currentfunction on an iterator and checking whether it's not null.