Make more properties readonly

src/Psalm/Internal/Analyzer/AttributesAnalyzer.php

@@ -264,7 +264,7 @@ private static function getAttributeClassFlags(
                     return self::TARGET_ALL; // Defaults to TARGET_ALL
                 }
 
-                $first_arg = reset($attribute_attribute->args);
+                $first_arg = $attribute_attribute->args[array_key_first($attribute_attribute->args)];
 
                 $first_arg_type = $first_arg->type;
 

src/Psalm/Internal/Analyzer/DataFlowNodeData.php

@@ -15,17 +15,17 @@ final class DataFlowNodeData
     use ImmutableNonCloneableTrait;
 
     public function __construct(
-        public string $label,
-        public int $line_from,
-        public int $line_to,
-        public string $file_name,
-        public string $file_path,
-        public string $snippet,
-        public int $from,
-        public int $to,
-        public int $snippet_from,
-        public int $column_from,
-        public int $column_to,
+        public readonly string $label,
+        public readonly int $line_from,
+        public readonly int $line_to,
+        public readonly string $file_name,
+        public readonly string $file_path,
+        public readonly string $snippet,
+        public readonly int $from,
+        public readonly int $to,
+        public readonly int $snippet_from,
+        public readonly int $column_from,
+        public readonly int $column_to,
     ) {
     }
 }

src/Psalm/Internal/Analyzer/Statements/Expression/Call/HighOrderFunctionArgInfo.php

@@ -27,7 +27,7 @@ final class HighOrderFunctionArgInfo
      */
     public function __construct(
         private readonly string $type,
-        private readonly FunctionLikeStorage $function_storage,
+        private functionLikeStorage $function_storage,
         private readonly ?ClassLikeStorage $class_storage = null,
     ) {
     }

src/Psalm/Internal/DataFlow/Path.php

@@ -19,10 +19,10 @@ final class Path
      * @param ?array<string> $escaped_taints
      */
     public function __construct(
-        public string $type,
-        public int $length,
-        public ?array $unescaped_taints = null,
-        public ?array $escaped_taints = null,
+        public readonly string $type,
+        public readonly int $length,
+        public readonly ?array $unescaped_taints = null,
+        public readonly ?array $escaped_taints = null,
     ) {
     }
 }

src/Psalm/Internal/Diff/DiffElem.php

@@ -22,11 +22,11 @@ final class DiffElem
 
     public function __construct(
         /** @var int One of the TYPE_* constants */
-        public int $type,
+        public readonly int $type,
         /** @var mixed Is null for add operations */
-        public mixed $old,
+        public readonly mixed $old,
         /** @var mixed Is null for remove operations */
-        public mixed $new,
+        public readonly mixed $new,
     ) {
     }
 }

src/Psalm/Internal/FileManipulation/CodeMigration.php

@@ -15,11 +15,11 @@ final class CodeMigration
     use ImmutableNonCloneableTrait;
 
     public function __construct(
-        public string $source_file_path,
-        public int $source_start,
-        public int $source_end,
-        public string $destination_file_path,
-        public int $destination_start,
+        public readonly string $source_file_path,
+        public readonly int $source_start,
+        public readonly int $source_end,
+        public readonly string $destination_file_path,
+        public readonly int $destination_start,
     ) {
     }
 }

src/Psalm/Internal/Fork/ForkProcessDoneMessage.php

@@ -14,7 +14,7 @@ final class ForkProcessDoneMessage implements ForkMessage
 {
     use ImmutableNonCloneableTrait;
 
-    public function __construct(public mixed $data)
+    public function __construct(public readonly mixed $data)
     {
     }
 }

src/Psalm/Internal/Fork/ForkProcessErrorMessage.php

@@ -14,7 +14,7 @@ final class ForkProcessErrorMessage implements ForkMessage
 {
     use ImmutableNonCloneableTrait;
 
-    public function __construct(public string $message)
+    public function __construct(public readonly string $message)
     {
     }
 }

src/Psalm/Internal/Fork/ForkTaskDoneMessage.php

@@ -14,7 +14,7 @@ final class ForkTaskDoneMessage implements ForkMessage
 {
     use ImmutableNonCloneableTrait;
 
-    public function __construct(public mixed $data)
+    public function __construct(public readonly mixed $data)
     {
     }
 }

src/Psalm/Internal/MethodIdentifier.php

@@ -25,7 +25,7 @@ final class MethodIdentifier implements Stringable
     /**
      * @param lowercase-string $method_name
      */
-    public function __construct(public string $fq_class_name, public string $method_name)
+    public function __construct(public readonly string $fq_class_name, public readonly string $method_name)
     {
     }
 

src/Psalm/Internal/Scanner/UnresolvedConstant/ArrayOffsetFetch.php

@@ -12,7 +12,7 @@
  */
 final class ArrayOffsetFetch extends UnresolvedConstantComponent
 {
-    public function __construct(public UnresolvedConstantComponent $array, public UnresolvedConstantComponent $offset)
+    public function __construct(public readonly UnresolvedConstantComponent $array, public readonly UnresolvedConstantComponent $offset)
     {
     }
 }

src/Psalm/Internal/Scanner/UnresolvedConstant/ArraySpread.php

@@ -12,7 +12,7 @@
  */
 final class ArraySpread extends UnresolvedConstantComponent
 {
-    public function __construct(public UnresolvedConstantComponent $array)
+    public function __construct(public readonly UnresolvedConstantComponent $array)
     {
     }
 }

src/Psalm/Internal/Scanner/UnresolvedConstant/ArrayValue.php

@@ -13,7 +13,7 @@
 final class ArrayValue extends UnresolvedConstantComponent
 {
     /** @param list<KeyValuePair|ArraySpread> $entries */
-    public function __construct(public array $entries)
+    public function __construct(public readonly array $entries)
     {
     }
 }

src/Psalm/Internal/Scanner/UnresolvedConstant/ClassConstant.php

@@ -12,7 +12,7 @@
  */
 final class ClassConstant extends UnresolvedConstantComponent
 {
-    public function __construct(public string $fqcln, public string $name)
+    public function __construct(public readonly string $fqcln, public readonly string $name)
     {
     }
 }

src/Psalm/Internal/Scanner/UnresolvedConstant/Constant.php

@@ -12,7 +12,7 @@
  */
 final class Constant extends UnresolvedConstantComponent
 {
-    public function __construct(public string $name, public bool $is_fully_qualified)
+    public function __construct(public readonly string $name, public readonly bool $is_fully_qualified)
     {
     }
 }

src/Psalm/Internal/Scanner/UnresolvedConstant/EnumPropertyFetch.php

@@ -12,7 +12,7 @@
  */
 abstract class EnumPropertyFetch extends UnresolvedConstantComponent
 {
-    public function __construct(public string $fqcln, public string $case)
+    public function __construct(public readonly string $fqcln, public readonly string $case)
     {
     }
 }

src/Psalm/Internal/Scanner/UnresolvedConstant/KeyValuePair.php

@@ -12,7 +12,7 @@
  */
 final class KeyValuePair extends UnresolvedConstantComponent
 {
-    public function __construct(public ?UnresolvedConstantComponent $key, public UnresolvedConstantComponent $value)
+    public function __construct(public readonly ?UnresolvedConstantComponent $key, public readonly UnresolvedConstantComponent $value)
     {
     }
 }

src/Psalm/Internal/Scanner/UnresolvedConstant/ScalarValue.php

@@ -12,7 +12,7 @@
  */
 final class ScalarValue extends UnresolvedConstantComponent
 {
-    public function __construct(public string|int|float|bool|null $value)
+    public function __construct(public readonly string|int|float|bool|null $value)
     {
     }
 }

src/Psalm/Internal/Scanner/UnresolvedConstant/UnresolvedBinaryOp.php

@@ -15,7 +15,7 @@ abstract class UnresolvedBinaryOp extends UnresolvedConstantComponent
 {
     use ImmutableNonCloneableTrait;
 
-    public function __construct(public UnresolvedConstantComponent $left, public UnresolvedConstantComponent $right)
+    public function __construct(public readonly UnresolvedConstantComponent $left, public readonly UnresolvedConstantComponent $right)
     {
     }
 }

src/Psalm/Internal/Scanner/UnresolvedConstant/UnresolvedTernary.php

@@ -16,9 +16,9 @@ final class UnresolvedTernary extends UnresolvedConstantComponent
     use ImmutableNonCloneableTrait;
 
     public function __construct(
-        public UnresolvedConstantComponent $cond,
-        public ?UnresolvedConstantComponent $if,
-        public UnresolvedConstantComponent $else,
+        public readonly UnresolvedConstantComponent $cond,
+        public readonly ?UnresolvedConstantComponent $if,
+        public readonly UnresolvedConstantComponent $else,
     ) {
     }
 }

src/Psalm/Internal/Type/TypeAlias/InlineTypeAlias.php

@@ -18,7 +18,7 @@ final class InlineTypeAlias implements TypeAlias
     /**
      * @param list<array{0: string, 1: int, 2?: string}> $replacement_tokens
      */
-    public function __construct(public array $replacement_tokens)
+    public function __construct(public readonly array $replacement_tokens)
     {
     }
 }

src/Psalm/Internal/Type/TypeAlias/LinkableTypeAlias.php

@@ -16,11 +16,11 @@ final class LinkableTypeAlias implements TypeAlias
     use ImmutableNonCloneableTrait;
 
     public function __construct(
-        public string $declaring_fq_classlike_name,
-        public string $alias_name,
-        public int $line_number,
-        public int $start_offset,
-        public int $end_offset,
+        public readonly string $declaring_fq_classlike_name,
+        public readonly string $alias_name,
+        public readonly int $line_number,
+        public readonly int $start_offset,
+        public readonly int $end_offset,
     ) {
     }
 }

src/Psalm/Storage/Assertion/HasArrayKey.php

@@ -12,7 +12,7 @@
  */
 final class HasArrayKey extends Assertion
 {
-    public function __construct(public readonly readonly string $key)
+    public function __construct(public readonly string $key)
     {
     }
 

src/Psalm/Storage/Assertion/IsNotCountable.php

@@ -11,7 +11,7 @@
  */
 final class IsNotCountable extends Assertion
 {
-    public function __construct(public readonly readonly bool $is_negatable)
+    public function __construct(public readonly bool $is_negatable)
     {
     }
 

src/Psalm/Storage/Assertion/NonEmptyCountable.php

@@ -11,7 +11,7 @@
  */
 final class NonEmptyCountable extends Assertion
 {
-    public function __construct(public readonly readonly bool $is_negatable)
+    public function __construct(public readonly bool $is_negatable)
     {
     }
 

src/Psalm/Storage/Assertion/NotInArray.php

@@ -13,7 +13,7 @@
 final class NotInArray extends Assertion
 {
     public function __construct(
-        public readonly readonly Union $type,
+        public readonly Union $type,
     ) {
     }
 

src/Psalm/Storage/AttributeArg.php

@@ -17,9 +17,9 @@ final class AttributeArg
     use ImmutableNonCloneableTrait;
 
     public function __construct(
-        public ?string $name,
-        public Union|UnresolvedConstantComponent $type,
-        public CodeLocation $location,
+        public readonly ?string $name,
+        public readonly Union|UnresolvedConstantComponent $type,
+        public readonly CodeLocation $location,
     ) {
     }
 }

src/Psalm/Storage/AttributeStorage.php

@@ -18,10 +18,10 @@ final class AttributeStorage
      * @param list<AttributeArg> $args
      */
     public function __construct(
-        public string $fq_class_name,
-        public array $args,
-        public CodeLocation $location,
-        public CodeLocation $name_location,
+        public readonly string $fq_class_name,
+        public readonly array $args,
+        public readonly CodeLocation $location,
+        public readonly CodeLocation $name_location,
     ) {
     }
 }

src/Psalm/Storage/ClassConstantStorage.php

@@ -36,16 +36,16 @@ public function __construct(
          * The type inferred from the value.
          */
         public ?Union $inferred_type,
-        public int $visibility,
-        public ?CodeLocation $location,
-        public ?CodeLocation $type_location = null,
-        public ?CodeLocation $stmt_location = null,
-        public bool $deprecated = false,
-        public bool $final = false,
-        public ?UnresolvedConstantComponent $unresolved_node = null,
-        public array $attributes = [],
-        public array $suppressed_issues = [],
-        public ?string $description = null,
+        public readonly int $visibility,
+        public readonly ?CodeLocation $location,
+        public readonly ?CodeLocation $type_location = null,
+        public readonly ?CodeLocation $stmt_location = null,
+        public readonly bool $deprecated = false,
+        public readonly bool $final = false,
+        public readonly ?UnresolvedConstantComponent $unresolved_node = null,
+        public readonly array $attributes = [],
+        public readonly array $suppressed_issues = [],
+        public readonly ?string $description = null,
     ) {
     }