Update Make.php #1074
Merged
Update Make.php #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checa uma propriedade de emit como elemento dom, sem checar se ele ja foi setado ou não. Deveria criar um default como fiz no código ou subir um erro obrigando a ordem de preenchimento das tags.
|
Ou ainda remover essa validação, tornando a responsabilidade de quem implementou. |
chore: correção não iria retornar o valor e sim um 'true'
chore: validando se o item do objeto DOM está preenchido antes de pegar o valor do node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checa uma propriedade de emit como elemento dom, sem checar se ele ja foi setado ou não. Deveria criar um default como fiz no código ou subir um erro obrigando a ordem de preenchimento das tags.