Skip to content

Commit

Permalink
Fix /cast/conversion response in readme (#221)
Browse files Browse the repository at this point in the history
  • Loading branch information
Shreyaschorge authored Oct 10, 2024
1 parent ad6b89b commit 780faad
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
- [ ] I have validated that all new/updated endpoints conform to OAS standards.
- [ ] I have updated or added necessary schema definitions.
- [ ] I have ensured that the new schema I have added doesn't exist.
- [ ] I have added description where ever necessary.
- [ ] I have added description wherever necessary.
- [ ] I have ensured that endpoint's responses are correct.
- [ ] I have considered backward compatibility with previous versions of the API.
- [ ] I have communicated any breaking changes to the appropriate stakeholders.
Expand Down
18 changes: 16 additions & 2 deletions src/v2/spec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1590,7 +1590,21 @@ components:
direct_replies:
type: array
items:
$ref: "#/components/schemas/CastWithInteractionsAndConversations"
$ref: "#/components/schemas/CastWithInteractionsAndConversationsRef"
description: "note: This is recursive. It contains the direct replies to the cast and their direct replies up to n reply_depth."
CastWithInteractionsAndConversationsRef:
description: Reference to CastWithInteractionsAndConversations to avoid circular reference
type: object
required:
- direct_replies
allOf:
- $ref: "#/components/schemas/CastWithInteractions"
- type: object
properties:
direct_replies:
type: array
items:
type: object
description: "note: This is recursive. It contains the direct replies to the cast and their direct replies up to n reply_depth."
Conversation:
type: object
Expand Down Expand Up @@ -7657,4 +7671,4 @@ paths:
# "400":
# $ref: "#/components/responses/400Response"
# "404":
# $ref: "#/components/responses/404Response"
# $ref: "#/components/responses/404Response"

0 comments on commit 780faad

Please sign in to comment.