Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused rules/scripts #31

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Remove unused rules/scripts #31

merged 2 commits into from
Aug 18, 2023

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Aug 9, 2023

Description of proposed changes

Removing some (maybe not all) unused things to make other efforts easier.

Related issue(s)

Testing

  • Checks pass
  • Partial ingest workflow runs locally without errors (excluding S3 upload failures)
  • Post-merge: Run rebuild and make sure it is successful. One of the Auspice JSON files is s3://nextstrain-data/rsv_a_genome.json version ID mIQsKXYBojEfXryS1NvJet.KrUBcEXUS

This file was referenced in 78f9a3d,
but that reference was removed in 9519413.

A file of the same name and contents was added under ingest/bin in
a678f0f and renamed in b8a3dea.
@victorlin victorlin self-assigned this Aug 9, 2023
These were copied in bulk¹ (presumably from the monkeypox repo) and
lightly modified for the RSV repo. Upload to S3 is being used, however
there are no plans to set up Slack notifications².

¹ 767e620, 3f7d3c0, 78f9a3d, c369850
² https://bedfordlab.slack.com/archives/C03BBQ62RSL/p1690848290852899
@victorlin victorlin mentioned this pull request Aug 9, 2023
3 tasks
@victorlin victorlin merged commit 75d4c07 into master Aug 18, 2023
6 checks passed
@victorlin victorlin deleted the victorlin/remove-unused branch August 18, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants