Skip to content

Commit

Permalink
Throw error when :render-fn is not a list or symbol (#699)
Browse files Browse the repository at this point in the history
When called in JVM Clojure.
  • Loading branch information
philippamarkovics authored Oct 7, 2024
1 parent 4e1a6ad commit 6c7e35e
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 2 deletions.
12 changes: 11 additions & 1 deletion src/nextjournal/clerk/viewer.cljc
Original file line number Diff line number Diff line change
Expand Up @@ -1555,13 +1555,23 @@
(.update hasher (goog.crypt/stringToUtf8ByteArray (pr-str x)))
(.digest hasher))))

(defn validate-viewer! [{:as viewer :keys [render-fn]}]
#?(:clj (when (and render-fn (not (or (list? render-fn)
(symbol? render-fn))))
(throw (ex-info (str "`:render-fn` must to be a quoted form or symbol, got a "
(if (fn? render-fn) "function" (type render-fn))
" instead.")
{:viewer viewer
:render-fn-type (type render-fn)})))))

(defn process-viewer [viewer {:nextjournal/keys [render-evaluator]}]
;; TODO: drop wrapped-value arg here and handle this elsewhere by
;; passing modified viewer stack
;; `(clerk/update-viewers viewers {:render-fn #(assoc % :render-evaluator :cherry)})`
(if-not (map? viewer)
viewer
(-> viewer
(-> (doto viewer
validate-viewer!)
(cond-> (and (not (:render-evaluator viewer)) render-evaluator)
(assoc :render-evaluator render-evaluator))
(dissoc :add-viewers :pred :transform-fn :update-viewers-fn)
Expand Down
6 changes: 5 additions & 1 deletion test/nextjournal/clerk/viewer_test.clj
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,11 @@

(is (= (v/present (v/with-viewer v/html-viewer [:h1 "ahoi"]))
(v/present {:nextjournal/value (v/with-viewer v/html-viewer [:h1 "ahoi"])})
(v/present {:nextjournal/value {:nextjournal/value (v/with-viewer v/html-viewer [:h1 "ahoi"])}})))))
(v/present {:nextjournal/value {:nextjournal/value (v/with-viewer v/html-viewer [:h1 "ahoi"])}}))))

(testing "invalid `:render-fn` throws error"
(is (thrown? clojure.lang.ExceptionInfo
(v/present (v/with-viewer {:render-fn (fn [x] [:h1 x])} "Mike"))))))

(deftest present-exceptions
(testing "can represent ex-data in a readable way"
Expand Down

0 comments on commit 6c7e35e

Please sign in to comment.