Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable29] fix(files): Ensure renaming state is correctly reset #48797

Draft
wants to merge 2 commits into
base: stable29
Choose a base branch
from
Draft

[stable29] fix(files): Ensure renaming state is correctly reset #48797

wants to merge 2 commits into from
+83 −11

Commits on Oct 18, 2024

  1. fix(files): Ensure renaming state is correctly reset 

    Problem: Is a node is renamed and the new name is out of the current
visible list of nodes the component will be recycled, this means
the props will change, so when the `onRename` functions is about to reset
the state the `this.source` will point to a different node.

To fix this, but also to separate business logic from visual representation,
the logic is moved into the renaming store and the component is only
responsible for rendering.

Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux @backportbot
    susnux authored and backportbot[bot] committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d6369c3 View commit details
    Browse the repository at this point in the history

  2. chore(assets): Recompile assets 

    Signed-off-by: nextcloud-command <[email protected]>
    @nextcloud-command @backportbot
    nextcloud-command authored and backportbot[bot] committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ab0f13d View commit details
    Browse the repository at this point in the history