chore(db): redirect write queries to master in clustered setups #48712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solracsf
added
3. to review
solracsf
requested review from
nickvergessen,
ChristophWurst,
miaulalala and
tcitworld
as code owners
lib/private/Comments/Manager.php
Outdated
| @@ -1303,7 +1302,7 @@ public function deleteCommentsAtObject($objectType, $objectId) { | |||
| ->andWhere($qb->expr()->eq('object_id', $qb->createParameter('id'))) | |||
| ->setParameter('type', $objectType) | |||
| ->setParameter('id', $objectId) | |||
| ->execute(); | |||
| ->executeStatement(); | |||
|
|
|||
| $this->commentsCache = []; | |||
|
|
|||
nickvergessen
approved these changes
Oct 15, 2024
miaulalala
approved these changes
Oct 15, 2024
solracsf
force-pushed
the
dbQueriesToMaster
branch
4 times, most recently
from
7eea27b
to
f76e605
Compare
fix: psalm baseline fix: remove is_int fix: return bool fix: lint fix: lint
solracsf
force-pushed
the
dbQueriesToMaster
branch
from
f76e605
to
8e41bc9
Compare
solracsf
force-pushed
the
dbQueriesToMaster
branch
3 times, most recently
from
dd55615
to
e7b1d5d
Compare
fix: psalm baseline fix: remove is_int fix: return bool fix: lint fix: cache fix: constraint violation fix: typo fix: tests
solracsf
force-pushed
the
dbQueriesToMaster
branch
from
e7b1d5d
to
d826e76
Compare
solracsf
added
2. developing
|
CI is failing. I'll debug it ASAP. |
… into dbQueriesToMaster
…oud/server into dbQueriesToMaster" This reverts commit ab6c1a9, reversing changes made to 8e41bc9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
Checklist