[stable25] fix(dav): Always respond custom error page on exceptions #48304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
artonge
force-pushed
the
backport/48297/stable25
branch
from
b407afd
to
71582d2
Compare
artonge
approved these changes
Sep 24, 2024
artonge
changed the title
artonge
force-pushed
the
backport/48297/stable25
branch
from
71582d2
to
0d488df
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (BrowserErrorPagePlugin::isBrowserRequest($request)) { | ||
| $this->server->addPlugin(new BrowserErrorPagePlugin()); | ||
| } | ||
| $this->server->addPlugin(new ErrorPagePlugin($this->request, \OC::$server->getConfig())); |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
artonge
changed the title
artonge
force-pushed
the
backport/48297/stable25
branch
2 times, most recently
from
20d9af7
to
c513c09
Compare
| public function logException(\Throwable $ex): void { | ||
| if ($ex instanceof Exception) { | ||
| $httpCode = $ex->getHTTPCode(); | ||
| $headers = $ex->getHTTPHeaders($this->server); |
Check notice
Code scanning / Psalm
PossiblyNullArgument Note
| $httpCode = 500; | ||
| $headers = []; | ||
| } | ||
| $this->server->httpResponse->addHeaders($headers); |
Check notice
Code scanning / Psalm
PossiblyNullPropertyFetch Note
| $httpCode = 500; | ||
| $headers = []; | ||
| } | ||
| $this->server->httpResponse->addHeaders($headers); |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
| } else { | ||
| $templateName = 'xml_exception'; | ||
| $renderAs = null; | ||
| $this->server->httpResponse->setHeader('Content-Type', 'application/xml; charset=utf-8'); |
Check notice
Code scanning / Psalm
PossiblyNullPropertyFetch Note
| /** | ||
| * @codeCoverageIgnore | ||
| */ | ||
| public function sendResponse() { |
Check notice
Code scanning / Psalm
MissingReturnType Note
| * @codeCoverageIgnore | ||
| */ | ||
| public function sendResponse() { | ||
| $this->server->sapi->sendResponse($this->server->httpResponse); |
Check notice
Code scanning / Psalm
PossiblyNullPropertyFetch Note
| * @codeCoverageIgnore | ||
| */ | ||
| public function sendResponse() { | ||
| $this->server->sapi->sendResponse($this->server->httpResponse); |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
| * @codeCoverageIgnore | ||
| */ | ||
| public function sendResponse() { | ||
| $this->server->sapi->sendResponse($this->server->httpResponse); |
Check notice
Code scanning / Psalm
PossiblyNullPropertyFetch Note
| * @codeCoverageIgnore | ||
| */ | ||
| public function sendResponse() { | ||
| $this->server->sapi->sendResponse($this->server->httpResponse); |
Check notice
Code scanning / Psalm
PossiblyNullArgument Note
artonge
force-pushed
the
backport/48297/stable25
branch
from
c513c09
to
8c3e687
Compare
provokateurin
approved these changes
Sep 25, 2024
artonge
force-pushed
the
backport/48297/stable25
branch
from
8c3e687
to
972fcb2
Compare
come-nc
approved these changes
Sep 26, 2024
artonge
force-pushed
the
backport/48297/stable25
branch
2 times, most recently
from
d8e966a
to
a7d821d
Compare
Signed-off-by: Louis Chemineau <[email protected]>
The `<?xml` tag is interpreted as PHP short tags, so this causes errors. Instead just print that part of the template. Signed-off-by: Ferdinand Thiessen <[email protected]>
…utput Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
backport/48297/stable25
branch
2 times, most recently
from
15b695d
to
fc6ab73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #48297
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.