feat: mail provider settings #48134
feat: mail provider settings #48134
Conversation
SebastianKrupinski
commented
Sep 17, 2024
SebastianKrupinski
commented
- Resolves: #Calendar invites: Administrator shall choose if server's or user's email address is used #5080
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
SebastianKrupinski
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
|
New setting in administration section |
| 'section_id' => 'server', | ||
| 'storage_type' => DeclarativeSettingsTypes::STORAGE_TYPE_EXTERNAL, | ||
| 'title' => $this->l->t('System Mails'), | ||
| 'description' => $this->l->t('System e-mails are messages generated automatically by Nextcloud. They are sent for example when a share is created or when inviting attendees to a calendar event..'), |
There was a problem hiding this comment.
They are sent for example when a share is created
I find it weird to use "share is created" as an example because we don't use the mail provider there.
There was a problem hiding this comment.
This is what design wanted...
There was a problem hiding this comment.
I'm quite sure that design wanted a description of what the feature actually does. I can't imagine that design asked you to mention in the description that this feature toggle affects the behavior of the sharebyemail provider, whereas it doesn't affect it.
There was a problem hiding this comment.
Yep, if we don't use the mail provider there than the example is wrong and we should change it to something that is actually affected by the setting
| return; | ||
| } | ||
|
|
||
| if ($event instanceof DeclarativeSettingsSetValueEvent) { |
Check notice
Code scanning / Psalm
RedundantConditionGivenDocblockType
SebastianKrupinski
force-pushed
the
feat/mail-provider-settings
branch
from
04d3529
to
cce92cc
Compare
SebastianKrupinski
force-pushed
the
feat/mail-provider-settings
branch
from
9d2d55c
to
da9179b
Compare
|
Latest version |
| 'section_type' => DeclarativeSettingsTypes::SECTION_TYPE_ADMIN, | ||
| 'section_id' => 'server', | ||
| 'storage_type' => DeclarativeSettingsTypes::STORAGE_TYPE_EXTERNAL, | ||
| 'title' => $this->l->t('System Mails'), |
There was a problem hiding this comment.
I would prefer to use Mail Providers instead of System Mails. System Mails can mean anything.
There was a problem hiding this comment.
This is what design approved.
There was a problem hiding this comment.
I spoke with Marco, and he's okay with adjusting the text to make the feature easier to understand.
| 'section_id' => 'server', | ||
| 'storage_type' => DeclarativeSettingsTypes::STORAGE_TYPE_EXTERNAL, | ||
| 'title' => $this->l->t('System Mails'), | ||
| 'description' => $this->l->t('System emails are automatically generated by Nextcloud when people perform actions like inviting others to calendar events.'), |
There was a problem hiding this comment.
What do you think about:
Nextcloud 30 introduced a feature called mail provider to send emails through the user's personal email account when possible. Currently, it only works with calendar invitations. You need Nextcloud 30, Nextcloud Mail 4.1 and there must be an email account in Nextcloud Mail matching the email address of the user in Nextcloud.
I think we should try to explain what's necessary to make the feature work. The requirements Mail 4.0 + a matching email account should be explained somewhere, how should a user otherwise know how it works?
There was a problem hiding this comment.
We should have some documentation for https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/email_configuration.html
There was a problem hiding this comment.
It will be documented once it is actual merged.
There was a problem hiding this comment.
I believe it would be really helpful to adjust the description here, making the function easier to understand.
|
The Linter is failing. |
kesselb
dismissed
their stale review
config.sample.php update no longer required
SebastianKrupinski
force-pushed
the
feat/mail-provider-settings
branch
from
da9179b
to
293cc53
Compare
Signed-off-by: SebastianKrupinski <[email protected]>
Signed-off-by: SebastianKrupinski <[email protected]>
Signed-off-by: SebastianKrupinski <[email protected]>
Signed-off-by: SebastianKrupinski <[email protected]>
Signed-off-by: SebastianKrupinski <[email protected]>
Signed-off-by: SebastianKrupinski <[email protected]>
Signed-off-by: SebastianKrupinski <[email protected]>
Signed-off-by: SebastianKrupinski <[email protected]>
SebastianKrupinski
force-pushed
the
feat/mail-provider-settings
branch
from
293cc53
to
f922723
Compare
