IUserPreferences #47658

ArtificialOwl · 2024-08-31T02:46:59Z

replace IConfig's preferences-related method
tests

core/Migrations/Version31000Date20240814184402.php

lib/private/UserPreferences.php

lib/public/UserPreferences/ValueType.php

lib/private/UserPreferences.php

lib/public/UserPreferences/IUserPreferences.php

lib/private/AllConfig.php

lib/private/UserPreferences.php

lib/private/AllConfig.php

lib/private/UserPreferences.php

lib/private/AllConfig.php

lib/private/UserPreferences.php

lib/public/UserPreferences/ValueTypeDefinition.php

lib/private/UserPreferences.php

+ $value = $cache[$app][$key];
+ try {
+ $this->decryptSensitiveValue($userId, $app, $key, $value);
+ $value = $this->convertTypedValue($value, $typedAs ?? $this->getValueType($userId, (string)$app, $key, $lazy));


lib/private/UserPreferences.php

+ * @param string $value preference value
+ * @param bool $caseInsensitive non-case-sensitive search, only works if $value is a string
+ *
+ * @return list<string>


lib/private/UserPreferences.php

+ * @since 31.0.0
+ */
+ public function searchUsersByValueString(string $app, string $key, string $value, bool $caseInsensitive = false): array {
+ return $this->searchUsersByTypedValue($app, $key, $value, $caseInsensitive);


lib/private/UserPreferences.php

+ * @param string $key preference key
+ * @param array $values list of preference values
+ *
+ * @return list<string>


lib/private/UserPreferences.php

+ * @since 31.0.0
+ */
+ public function searchUsersByValues(string $app, string $key, array $values): array {
+ return $this->searchUsersByTypedValue($app, $key, $values);


lib/private/AllConfig.php

artonge · 2024-10-03T15:00:56Z

lib/private/UserPreferences.php

If possible, please split that file before it gets out of hand.

So, I thought about it .. even started to split into 3:

IUserPreferences for basic getters/setters on user preferences.

IUserPreferencesExtra that extendsIUserPreferences and add all direct value manipulation on the cache like is[Lazy|Sensitive|Indexed], update[Lazy|Sensitive|Indexed], ...

IAdvancedUserPreferences for search

but it makes everything bad. I will keep it like this (using a single file) until PHP can define a class from multiple files :-]

Please note that there is a lot of single line method that request 10 lines of PHPDoc ...

core/Migrations/Version31000Date20240814184402.php

lib/private/UserPreferences.php

come-nc

Stopped at line 1050 of UserPreferences, to be continued…

I dislike the sensitive flag thing, it should be a bool just like lazy so that all types var can be typed to the enum.

lib/private/AllConfig.php

come-nc · 2024-10-03T14:59:40Z

lib/private/UserPreferences.php

+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OC;


Avoid cluttering OC namespace please

Maybe move to \OC\UserPreferences\Manager ?

Moving everything into \OC\Config and \OCP\Config

lib/private/UserPreferences.php

artonge · 2024-10-03T16:27:38Z

lib/public/UserPreferences/IUserPreferences.php

Maybe let's keep it private for one major version to have the flexibility to change the API down the road?

core/Migrations/Version31000Date20240814184402.php

lib/private/UserPreferences.php

susnux

Just to note this somewhere (feel free to ignore):
For me the name if a bit confusing (I know the DB table is called like that),
as we have IConfig and IAppConfig I would expect IUserConfig as the name.

ArtificialOwl · 2024-10-17T12:07:11Z

Just to note this somewhere (feel free to ignore): For me the name if a bit confusing (I know the DB table is called like that), as we have IConfig and IAppConfig I would expect IUserConfig as the name.

While I think grouping API might happens if we start today to create this API within \[OC|OCP]\Config/` but I am still fine with IUserPreferences

lib/public/UserPreferences/ValueType.php

lib/private/AllConfig.php

core/Migrations/Version31000Date20240814184402.php

lib/private/UserPreferences.php

ArtificialOwl · 2024-10-17T12:05:08Z

lib/private/UserPreferences.php

+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OC;


Moving everything into \OC\Config and \OCP\Config

Signed-off-by: Maxence Lange <[email protected]>

github-advanced-security bot found potential problems Aug 31, 2024

View reviewed changes

ArtificialOwl force-pushed the enh/noid/user-preferences branch 2 times, most recently from 6d81b97 to a9e2a38 Compare August 31, 2024 22:30

github-advanced-security bot found potential problems Aug 31, 2024

View reviewed changes

lib/private/UserPreferences.php Fixed Show fixed Hide fixed

lib/private/UserPreferences.php Fixed Show fixed Hide fixed

lib/public/UserPreferences/IUserPreferences.php Fixed Show fixed Hide fixed

lib/public/UserPreferences/IUserPreferences.php Fixed Show fixed Hide fixed

ArtificialOwl force-pushed the enh/noid/user-preferences branch from e9ec009 to cda7029 Compare September 1, 2024 19:15

github-advanced-security bot found potential problems Sep 1, 2024

View reviewed changes

lib/private/AllConfig.php Fixed Show fixed Hide fixed

lib/private/AllConfig.php Fixed Show fixed Hide fixed

lib/private/UserPreferences.php Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Sep 1, 2024

View reviewed changes

lib/private/UserPreferences.php Fixed Show fixed Hide fixed

lib/private/UserPreferences.php Fixed Show fixed Hide fixed

ArtificialOwl force-pushed the enh/noid/user-preferences branch from 1fbb6a9 to 317202a Compare September 1, 2024 22:42

github-advanced-security bot found potential problems Sep 1, 2024

View reviewed changes

lib/private/AllConfig.php Fixed Show fixed Hide fixed

ArtificialOwl force-pushed the enh/noid/user-preferences branch from c78f304 to 979ecee Compare September 2, 2024 01:09

github-advanced-security bot found potential problems Sep 2, 2024

View reviewed changes

lib/private/AllConfig.php Fixed Show fixed Hide fixed

ArtificialOwl force-pushed the enh/noid/user-preferences branch from 979ecee to 41ba78f Compare September 2, 2024 01:19

github-advanced-security bot found potential problems Sep 2, 2024

View reviewed changes

lib/private/AllConfig.php Fixed Show fixed Hide fixed

ArtificialOwl force-pushed the enh/noid/user-preferences branch 2 times, most recently from 8edb1c1 to e510535 Compare September 2, 2024 02:31

github-advanced-security bot found potential problems Sep 2, 2024

View reviewed changes

lib/private/UserPreferences.php Fixed Show fixed Hide fixed

lib/private/UserPreferences.php Fixed Show fixed Hide fixed

ArtificialOwl force-pushed the enh/noid/user-preferences branch from f71bb7d to e24d29a Compare September 2, 2024 03:33

github-advanced-security bot found potential problems Sep 2, 2024

View reviewed changes

lib/private/AllConfig.php Fixed Show fixed Hide fixed

lib/private/AllConfig.php Fixed Show fixed Hide fixed

lib/private/AllConfig.php Fixed Show fixed Hide fixed

ArtificialOwl force-pushed the enh/noid/user-preferences branch 2 times, most recently from 32c209d to b80315b Compare September 2, 2024 14:57

github-advanced-security bot found potential problems Sep 2, 2024

View reviewed changes

lib/private/AllConfig.php Fixed Show fixed Hide fixed

lib/private/AllConfig.php Fixed Show fixed Hide fixed

ArtificialOwl force-pushed the enh/noid/user-preferences branch from b80315b to 0c489af Compare September 2, 2024 16:03

github-advanced-security bot found potential problems Sep 2, 2024

View reviewed changes

lib/private/UserPreferences.php Fixed Show fixed Hide fixed

ArtificialOwl force-pushed the enh/noid/user-preferences branch from 0c489af to 6ae7f9f Compare September 2, 2024 19:50

susnux reviewed Sep 5, 2024

View reviewed changes

lib/public/UserPreferences/ValueTypeDefinition.php Outdated Show resolved Hide resolved

ArtificialOwl force-pushed the enh/noid/user-preferences branch from ceb814d to a219133 Compare September 30, 2024 16:25

ArtificialOwl marked this pull request as ready for review September 30, 2024 16:26

ArtificialOwl added the 3. to review Waiting for reviews label Sep 30, 2024

ArtificialOwl added this to the Nextcloud 31 milestone Sep 30, 2024

github-advanced-security bot found potential problems Sep 30, 2024

View reviewed changes

ArtificialOwl force-pushed the enh/noid/user-preferences branch 3 times, most recently from cc4a1ff to da769f0 Compare October 3, 2024 13:52

artonge reviewed Oct 3, 2024

View reviewed changes

core/Migrations/Version31000Date20240814184402.php Show resolved Hide resolved

artonge reviewed Oct 3, 2024

View reviewed changes

lib/private/UserPreferences.php Outdated Show resolved Hide resolved

come-nc reviewed Oct 3, 2024

View reviewed changes

artonge reviewed Oct 3, 2024

View reviewed changes

susnux reviewed Oct 10, 2024

View reviewed changes

core/Migrations/Version31000Date20240814184402.php Show resolved Hide resolved

susnux reviewed Oct 10, 2024

View reviewed changes

lib/private/UserPreferences.php Outdated Show resolved Hide resolved

susnux reviewed Oct 10, 2024

View reviewed changes

lib/private/UserPreferences.php Outdated Show resolved Hide resolved

susnux reviewed Oct 11, 2024

View reviewed changes

ArtificialOwl force-pushed the enh/noid/user-preferences branch from 6e0abf9 to e04730a Compare October 17, 2024 09:49

ArtificialOwl commented Oct 17, 2024

View reviewed changes

ArtificialOwl force-pushed the enh/noid/user-preferences branch 4 times, most recently from 17eeef9 to 6a3a4a1 Compare October 21, 2024 17:30

ArtificialOwl added 3 commits October 21, 2024 18:31

feat(user-prefs): IUserPreferences

3efb07b

Signed-off-by: Maxence Lange <[email protected]>

fix(user-prefs): adding sensitive and indexed as flags

b099644

Signed-off-by: Maxence Lange <[email protected]>

feat(user-prefs): iterator instead of array on search

ebeff96

Signed-off-by: Maxence Lange <[email protected]>

ArtificialOwl force-pushed the enh/noid/user-preferences branch from 6a3a4a1 to ebeff96 Compare October 21, 2024 19:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IUserPreferences #47658

IUserPreferences #47658

ArtificialOwl commented Aug 31, 2024 •

edited

Loading

artonge Oct 3, 2024

ArtificialOwl Oct 17, 2024

come-nc left a comment

come-nc Oct 3, 2024

susnux Oct 10, 2024

ArtificialOwl Oct 17, 2024

artonge Oct 3, 2024

susnux left a comment

ArtificialOwl commented Oct 17, 2024

ArtificialOwl Oct 17, 2024

IUserPreferences #47658

Are you sure you want to change the base?

IUserPreferences #47658

Conversation

ArtificialOwl commented Aug 31, 2024 • edited Loading

artonge Oct 3, 2024

Choose a reason for hiding this comment

ArtificialOwl Oct 17, 2024

Choose a reason for hiding this comment

come-nc left a comment

Choose a reason for hiding this comment

come-nc Oct 3, 2024

Choose a reason for hiding this comment

susnux Oct 10, 2024

Choose a reason for hiding this comment

ArtificialOwl Oct 17, 2024

Choose a reason for hiding this comment

artonge Oct 3, 2024

Choose a reason for hiding this comment

susnux left a comment

Choose a reason for hiding this comment

ArtificialOwl commented Oct 17, 2024

ArtificialOwl Oct 17, 2024

Choose a reason for hiding this comment

ArtificialOwl commented Aug 31, 2024 •

edited

Loading