fix: Throw instead of yielding nothing when listing local directories

Signed-off-by: Julius Härtl <[email protected]> Signed-off-by: Max <[email protected]>
nextcloud · Feb 27, 2024 · cdc4dac · cdc4dac
1 parent 822e763
commit cdc4dac
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/lib/private/Files/Storage/Common.php b/lib/private/Files/Storage/Common.php
@@ -60,6 +60,7 @@
 use OCP\Files\Storage\ILockingStorage;
 use OCP\Files\Storage\IStorage;
 use OCP\Files\Storage\IWriteStreamStorage;
+use OCP\Files\Storage\StorageNotAvailableException;
 use OCP\ILogger;
 use OCP\Lock\ILockingProvider;
 use OCP\Lock\LockedException;
@@ -877,6 +878,11 @@ public function writeStream(string $path, $stream, int $size = null): int {
 
  public function getDirectoryContent($directory): \Traversable {
  $dh = $this->opendir($directory);
+
+ if ($dh === false) {
+ throw new StorageNotAvailableException('Directory listing failed');
+ }
+
  if (is_resource($dh)) {
  $basePath = rtrim($directory, '/');
  while (($file = readdir($dh)) !== false) {