FIREWALL: Use rich rules instead of direct rules #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrezina
reviewed
Jul 18, 2024
aplopez
force-pushed
the
rich-rules
branch
2 times, most recently
from
e417fb2
to
58ba70d
Compare
ikerexxe
reviewed
Jul 18, 2024
ikerexxe
approved these changes
Jul 19, 2024
pbrezina
reviewed
Jul 19, 2024
pbrezina
reviewed
Jul 19, 2024
There was a problem hiding this comment.
I didn't review the code, but it looks ok conceptually.
As a rule of thumb - don't call any commands in init, use setup for that. This way, it is possible to call setup only when something from the utils is actually used (see mh_postpone_setup). And every change done must be reverted in teardown so we do not polute other tests.
|
Bump @thalman |
thalman
approved these changes
Aug 2, 2024
|
@aplopez Please, resolve conflict and we can merge. |
Direct rules have been deprecated for some time now, so we switch to using rich rules. However, we need a specific policy to which the rule will be applied. This policy is permanent (a requirement) and is created at start up, deleted at teardown, and remains active during the whole test. Only the rules are dynamic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct rules have been deprecated for some time now, so we switch to using rich rules.
However, we need a specific policy to which the rule will be applied. This policy is permanent (a requirement) and is created at setup, deleted at teardown, and remains active during the whole test. Only the rules are dynamic.
This works on RHEL 8 thourgh 10.