Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting and code styles #110

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Linting and code styles #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
02d5325
Adding eslint and packages and adding lint npm scripts.
Jan 3, 2019
eb73b05
Comment about globals from illustrator.
Jan 3, 2019
3dca20d
Globals for linting.
Jan 3, 2019
d5c6c77
Don't worry about legacy.
Jan 3, 2019
363e836
Add globals to config.
Jan 3, 2019
e39b509
Adding editorconfig.
Jan 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# http://editorconfig.org
root = true

[*]
indent_style = space
indent_size = 2
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

[*.md]
trim_trailing_whitespace = false
40 changes: 40 additions & 0 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
{
"extends": ["eslint:recommended", "plugin:es5/no-es2015"],
"env": {
"browser": true,
"node": true
},
"rules": {
"semi": ["error", "always"],
"quotes": ["error", "double"]
},
"globals": {
"app": true,
"alert": true,
"confirm": true,
"Folder": true,
"File": true,
"DocumentColorSpace": true,
"IllustratorSaveOptions": true,
"ZOrderMethod": true,
"TextType": true,
"Window": true,
"BlendModes": true,
"ElementPlacement": true,
"PointType": true,
"ExportType": true,
"ExportOptionsPNG8": true,
"ExportOptionsPNG24": true,
"ExportOptionsJPEG": true,
"ExportOptionsSVG": true,
"SVGFontSubsetting": true,
"SVGDocumentEncoding": true,
"SVGDTDVersion": true,
"SVGCSSPropertyLocation": true,
"SaveOptions": true,
"Event": true,
"$": true,
"it": true,
"describe": true
}
}
3 changes: 3 additions & 0 deletions ai2html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@
// - Go to the folder containing your Illustrator file. Inside will be a folder called ai2html-output.
// - Open the html files in your browser to preview your output.

// Globals available from Illustrator
// https://www.adobe.com/devnet/illustrator/scripting.html

function main() {
// Enclosing scripts in a named function (and not an anonymous, self-executing
// function) has been recommended as a way to minimise intermittent "MRAP" errors.
Expand Down
10 changes: 7 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@
"name": "ai2html",
"version": "0.81.4",
"description": "A script for Adobe Illustrator that converts your Illustrator artwork into an html page.",
"main": "./ai2html.js",
"scripts": {
"main": "./ai2html.js",
"scripts": {
"test": "mocha --check-leaks",
"prepublishOnly": "./prepublish.sh"
"prepublishOnly": "./prepublish.sh",
"lint": "eslint ai2html*.js test/**/*js",
"lintFix": "eslint ai2html.js test/**/*js --fix"
},
"repository": {
"type": "git",
Expand All @@ -17,6 +19,8 @@
"url": "https://github.com/newsdev/ai2html/issues"
},
"devDependencies": {
"eslint": "^5.11.1",
"eslint-plugin-es5": "^1.3.1",
"mocha": ">=3.2.0"
},
"homepage": "https://github.com/newsdev/ai2html#readme"
Expand Down