Remove excess info-level instrumentation logs #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods prepend_instrument and chain_instrument log instrumentation statements. Duplicate statements are now removed.
hannahramadan
requested review from
fallwith,
kaylareopelle and
tannalynn
as code owners
SimpleCov Report
|
fallwith
reviewed
Oct 4, 2024
lib/tasks/instrumentation_generator/templates/dependency_detection.tt
Outdated
Show resolved
Hide resolved
…tion.tt Co-authored-by: James Bunch <[email protected]>
fallwith
approved these changes
Oct 4, 2024
kaylareopelle
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes info-level log statements for instrumentations. These statements are already produces in the
prepend_instrumentandchain_instrumentmethods, which calllog_and_instrument. Each instrumentation file edited in this PR uses these methods.The library name used for a supportability metric and logging statement is either extracted via
extract_supportability_name, which splits on the 2nd to last spot of the instrumented module, or can be passed in as a third argument toprepend_instrumentorchain_instrument. For libraries that have a weird 2nd to last name, a third argument was added with the desired name.closes #2434