unit test and CHANGELOG entry for 2870 #2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unit test branch coverage and a CHANGELOG bugfix writeup to accompany PR 2870
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
SimpleCov Report
|
| @@ -78,6 +78,10 @@ Version 9.14.0 adds Apache Kafka instrumentation for the rdkafka and ruby-kafka | |||
|
|
|||
| To address a recent Bundler deprecation warning, we started using `Bundler.rubygems.installed_specs` instead of `Bundler.rubygems.all_specs` in environments that seemed appropriate. We discovered the version constraint we used was too low. Now, rather than check the version, we check for the method using `respond_to?`. [PR#2853](https://github.com/newrelic/newrelic-ruby-agent/pull/2853) | |||
|
|
|||
| - **Bugfix: Support view_component v3.15.0+** | |||
There was a problem hiding this comment.
Should we list this one on the top summary too?
There was a problem hiding this comment.
Sure, added in ad5f9b8
kaylareopelle
previously approved these changes
Sep 30, 2024
reference the ViewComponent community PR fix in the v9.14.0 summary
kaylareopelle
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit test branch coverage and a CHANGELOG bugfix writeup to accompany PR #2870