Re-enable Rails EDGE CI testing, address Rails v8.0-alpha specific issues #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fallwith
commented
Jul 17, 2024
fallwith
commented
- Re-enable CI testing of Rails EDGE
- Apply test fixes for Rails v8.0-alpha
- Drop ActiveRecord tests for gem versions below v4.0
resume CI testing of Rails EDGE (which currently references Rails v8.0 alpha)
- Use v8.0 defaults - Conditiionally include gems not included with Ruby v3.4 / v3.5
Don't expect the Rails notification to fire nor the 'chunked' header to be set by Rails v8.0.
Rails leaves things up to Rack, and so should we
Rails v8 won't set the "chunked" header value, so don't expect it for Rails v8+
- support Rails v8.0 - drop testing logic for Rails < v4.0
fix resulting from 5a94b9b
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
SimpleCov Report
|
kaylareopelle
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.