Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Lambda docs link #2747

Merged
merged 1 commit into from
Jul 12, 2024
Merged

update Lambda docs link #2747

merged 1 commit into from
Jul 12, 2024

Conversation

fallwith
Copy link
Contributor

the Lambda docs have been reorganized to accommodate what are being referred to as "layerless", "containerized", and "non-containerized" approaches, with that last one being the closest analogue to what was linked to previously.

the Lambda docs have been reorganized to accommodate what are being
referred to as "layerless", "containerized", and "non-containerized"
approaches, with that last one being the closest analogue to what was
linked to previously.
@@ -1956,7 +1956,7 @@ def self.enforce_fallback(allowed_values: nil, fallback: nil)
If `true`, the agent will operate in a streamlined mode suitable for use with short-lived serverless
functions. NOTE: Only AWS Lambda functions are supported currently and this option is not intended for use
without
[New Relic's Ruby Lambda layer](https://docs.newrelic.com/docs/serverless-function-monitoring/aws-lambda-monitoring/get-started/monitoring-aws-lambda-serverless-monitoring/)
[New Relic's Ruby Lambda layer based instrumentation](https://docs.newrelic.com/docs/serverless-function-monitoring/aws-lambda-monitoring/instrument-lambda-function/instrument-your-own/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[New Relic's Ruby Lambda layer based instrumentation](https://docs.newrelic.com/docs/serverless-function-monitoring/aws-lambda-monitoring/instrument-lambda-function/instrument-your-own/)
[New Relic's Ruby Lambda layer instrumentation](https://docs.newrelic.com/docs/serverless-function-monitoring/aws-lambda-monitoring/instrument-lambda-function/instrument-your-own/)

Maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case it's a layer that's delivering the instrumentation, and not itself being instrumented. So I tried to reflect that disambiguation with "layer based".

Copy link

SimpleCov Report

Coverage Threshold
Line 93.84% 93%
Branch 70.54% 50%

@fallwith fallwith merged commit 43234eb into dev Jul 12, 2024
33 checks passed
@fallwith fallwith deleted the λ📝 branch July 12, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants