Stripe testing update (#2891)

* Update Stripe test Co-authored-by: James Bunch <[email protected]> --------- Co-authored-by: James Bunch <[email protected]>
newrelic · Oct 4, 2024 · ffea529 · ffea529
1 parent f4f1305
commit ffea529
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/test/multiverse/suites/stripe/Envfile b/test/multiverse/suites/stripe/Envfile
@@ -7,8 +7,7 @@
 instrumentation_methods :chain
 
 STRIPE_VERSIONS = [
- # TODO: support Stripe v13+ https://github.com/newrelic/newrelic-ruby-agent/issues/2884
- # [nil, 2.4],
+ [nil, 2.4],
  ['12.6.0', 2.4],
  ['5.38.0', 2.4]
 ]

diff --git a/test/multiverse/suites/stripe/stripe_instrumentation_test.rb b/test/multiverse/suites/stripe/stripe_instrumentation_test.rb
@@ -199,9 +199,19 @@ def stripe_segment_from_transaction(txn)
  end
 
  def with_stubbed_connection_manager(&block)
- Stripe::StripeClient.stub(:default_connection_manager, @connection) do
- @connection.stub(:execute_request, @response) do
- yield
+ # Stripe moved StripeClient and requestor logic to APIRequestor in v13.0.0
+ # https://github.com/stripe/stripe-ruby/pull/1458
+ if Gem::Version.new(Stripe::VERSION) >= Gem::Version.new('13.0.0')
+ Stripe::APIRequestor.stub(:default_connection_manager, @connection) do
+ @connection.stub(:execute_request, @response) do
+ yield
+ end
+ end
+ else
+ Stripe::StripeClient.stub(:default_connection_manager, @connection) do
+ @connection.stub(:execute_request, @response) do
+ yield
+ end
  end
  end
  end