Skip to content

Commit

Permalink
Simplify excluded_settings test
Browse files Browse the repository at this point in the history
  • Loading branch information
kaylareopelle committed Oct 10, 2024
1 parent 1b18a18 commit c0091a3
Showing 1 changed file with 2 additions and 14 deletions.
16 changes: 2 additions & 14 deletions test/new_relic/agent/configuration/manager_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -533,20 +533,8 @@ def test_unsatisfied_values_stay_cached
def test_logger_does_not_receive_excluded_settings
log = with_array_logger(:debug) { @manager.log_config('direction', 'source') }.array.join('')

# TODO: OLD RUBIES - RUBY_VERSION < 3.4
# The JSON string output changed in Ruby 3.4 to remove the hash rocket
# Pre Ruby 3.4:
# :app_name=>\"test\"
# Ruby 3.4+:
# app_name: \"test\"
# Remove the condition once we support only version 3.4+
if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.4.0')
assert_includes(log, 'app_name:')
refute_includes(log, 'license_key:')
else
assert_includes(log, ':app_name')
refute_includes(log, ':license_key')
end
assert_includes(log, 'app_name')
refute_includes(log, 'license_key')
end

def test_reset_cache_return_early_for_jruby
Expand Down

0 comments on commit c0091a3

Please sign in to comment.