Skip to content

Commit

Permalink
Merge pull request #2908 from newrelic/trying_stuff_for_rdkafka_failures
Browse files Browse the repository at this point in the history
Rdkafka runs in its own multiverse group
  • Loading branch information
tannalynn authored Oct 14, 2024
2 parents 52bb44e + d97b9f2 commit 63eb706
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ jobs:
strategy:
fail-fast: false
matrix:
multiverse: [agent, ai, background, background_2, database, frameworks, httpclients, httpclients_2, rails, rest]
multiverse: [agent, ai, background, background_2, kafka, database, frameworks, httpclients, httpclients_2, rails, rest]
ruby-version: [2.4.10, 3.3.5]

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci_cron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ jobs:
strategy:
fail-fast: false
matrix:
multiverse: [agent, ai, background, background_2, database, frameworks, httpclients, httpclients_2, rails, rest]
multiverse: [agent, ai, background, background_2, database, kafka, frameworks, httpclients, httpclients_2, rails, rest]
ruby-version: [2.4.10, 2.5.9, 2.6.10, 2.7.8, 3.0.7, 3.1.6, 3.2.5, 3.3.5, 3.4.0-preview2]
steps:
- name: Configure git
Expand Down
1 change: 1 addition & 0 deletions test/multiverse/lib/multiverse/runner.rb
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ def execute_suites(filter, opts)
'ai' => %w[ruby_openai],
'background' => %w[delayed_job sidekiq resque],
'background_2' => %w[rake],
'kafka' => %w[rdkafka],
'database' => %w[elasticsearch mongo redis sequel],
'rails' => %w[active_record active_record_pg active_support_broadcast_logger active_support_logger rails rails_prepend activemerchant],
'frameworks' => %w[grape padrino roda sinatra],
Expand Down
2 changes: 1 addition & 1 deletion test/multiverse/lib/multiverse/suite.rb
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ def child_command_line(env, instrumentation_method)

def check_for_failure(env)
if $? != 0
OutputCollector.write(suite, env, red("#{suite.inspect} for Envfile entry #{env} failed!"))
OutputCollector.write(suite, env, red("#{suite.inspect} for Envfile entry #{env} failed! (exit: #{$?})"))
OutputCollector.failed(suite, env)
end
Multiverse::Runner.notice_exit_status($?)
Expand Down

0 comments on commit 63eb706

Please sign in to comment.