Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address issues found during GitHub action multi arch build #144

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Address issues found during GitHub action multi arch build #144

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8db275a
Address issues found during GitHub action multi arch build
ddelnano Nov 21, 2023
cd13e9d
Use workflow version that allows skipping the helm chart release step
ddelnano Nov 22, 2023
b33c44a
Use parameter with correct logic
ddelnano Nov 22, 2023
76fb845
Use upstream workflow now that dependent change was merged
ddelnano Nov 27, 2023
b6412f1
Merge branch 'main' into ddelnano/fixes-for-failed-release-action
ddelnano Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
---
on:
release:
# Disable prereleased trigger since that requires opting into including the Helm chart
# in this repository.
# types: [prereleased, released]
types: [released]
types: [prereleased, released]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that docker images are pushed on the prerelease event (source)

tags:
- 'v*'
workflow_dispatch:
Expand Down
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ all: test build-container build
build:
sh scripts/build.sh

.PHONY: compile
compile: build

.PHONY: fmt
fmt:
sh scripts/format.sh
Expand Down
Loading