Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling configuration of jfr params #371

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

meiao
Copy link
Contributor

@meiao meiao commented Aug 16, 2021

Overview

Enables configuration of queue size and harvest interval for JFR data.

Related Github Issue

newrelic/newrelic-jfr-core#203

Checks

Are your contributions backwards compatible with relevant frameworks and APIs?
Yes
Does your code contain any breaking changes? Please describe.
No
Does your code introduce any new dependencies? Please describe.
No

@@ -18,12 +20,19 @@
public static final String AUDIT_LOGGING = "audit_logging";
public static final Boolean AUDIT_LOGGING_DEFAULT = Boolean.FALSE;
public static final Boolean USE_LICENSE_KEY_DEFAULT = Boolean.TRUE;
public static final String HARVEST_INTERVAL = "harvest_interval";
public static final String QUEUE_SIZE = "queue_size";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the intent is for these to be publicly configurable then we'll probably want them in the default yaml: https://github.com/newrelic/newrelic-java-agent/blob/main/newrelic-agent/src/main/resources/newrelic.yml#L274-L289

And also in the usage section of the readme: https://github.com/newrelic/newrelic-jfr-core#usage-for-new-relic-java-agent-jfr-service

Thats said, I'm not sure if the intent is for these to be publicized as of yet...

@meiao meiao marked this pull request as draft October 18, 2021 17:08
@kford-newrelic kford-newrelic added oct-dec qtr Represents proposed work item for the Oct-Dec quarter estimate Issue needing estimation labels Sep 7, 2023
@kford-newrelic
Copy link
Contributor

Feature Request submitted by a customer:

We would like to have the option to control the JFR EVENTS QUEUE SIZE on the Java APM agent side via an environment variable or newrelic.yml config file attribute.

This is so that apps that generate more than the New Relic designated default JFR event queue size don't lose that information before it's sent over to NewRelic.

If we can control the JFR Event Queue Size, we could also effectively stop the NR java agent spamming logs with "Getting error Rejecting RecordedEvent – queue is full" messages without having to disable JFR.

We are looking for functionality similar to the one described in (this PR)

@jasonjkeller
Copy link
Contributor

When deciding if the agent should impose limits on these new config options we should consider the limits imposed by the Metric API and Event API that JFR is sent to so that we can minimize the likelihood of data being rejected by the backend:

Also consider adding supportability metrics to record the values configured by customers to make troubleshooting easier.

@kford-newrelic kford-newrelic added 3 Story Point Estimate jan-mar qtr Represents proposed work item for the Jan-Mar quarter and removed estimate Issue needing estimation oct-dec qtr Represents proposed work item for the Oct-Dec quarter labels Sep 21, 2023
@kford-newrelic kford-newrelic removed the jan-mar qtr Represents proposed work item for the Jan-Mar quarter label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 Story Point Estimate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants