Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy init of GUIDs on DefaultTracers #2088

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Lazy init of GUIDs on DefaultTracers #2088

merged 2 commits into from
Oct 3, 2024

Conversation

jtduffy
Copy link
Contributor

@jtduffy jtduffy commented Oct 3, 2024

Closes #2057 from @yuzawa-san

The GUID for a tracer is only necessary if it's going to be reported up to NR. This change defers the creation of the GUID until the getGuid() call is made.

Another minor optimization was moving the hexchars const to a class level member.

@jtduffy jtduffy requested a review from a team October 3, 2024 14:04
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.59%. Comparing base (857433f) to head (6fba5c8).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2088   +/-   ##
=========================================
  Coverage     70.59%   70.59%           
+ Complexity     9883     9881    -2     
=========================================
  Files           829      829           
  Lines         39961    39961           
  Branches       6080     6081    +1     
=========================================
  Hits          28211    28211           
- Misses         9020     9021    +1     
+ Partials       2730     2729    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtduffy jtduffy merged commit 7cc5b0c into main Oct 3, 2024
111 checks passed
@jtduffy jtduffy deleted the lazy-guid-init branch October 3, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants