Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**DRAFT** feature: Modern Garbage Collection Metrics Sampler #2838

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

tippmar-nr
Copy link
Member

Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.

Description

The what, the why and the how of your PR.

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.27313% with 13 lines in your changes missing coverage. Please review.

Project coverage is 81.43%. Comparing base (a77919e) to head (0ab84ac).

Files with missing lines Patch % Lines
...t/Core/Samplers/GCSamplerModernReflectionHelper.cs 76.31% 7 Missing and 2 partials ⚠️
....Agent.Extensions/Reflection/VisibilityBypasser.cs 82.60% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2838      +/-   ##
==========================================
+ Coverage   81.31%   81.43%   +0.12%     
==========================================
  Files         460      464       +4     
  Lines       29239    29461     +222     
  Branches     3231     3255      +24     
==========================================
+ Hits        23777    23993     +216     
- Misses       4669     4674       +5     
- Partials      793      794       +1     
Flag Coverage Δ
Agent 82.34% <94.27%> (+0.12%) ⬆️
Profiler 73.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...wRelic/Agent/Core/Config/BootstrapConfiguration.cs 100.00% <100.00%> (ø)
...c/Agent/Core/Configuration/DefaultConfiguration.cs 89.58% <100.00%> (+0.01%) ⬆️
.../Agent/Core/Configuration/ReportedConfiguration.cs 95.74% <100.00%> (+0.01%) ⬆️
...ic/Agent/Core/DependencyInjection/AgentServices.cs 98.22% <100.00%> (+0.13%) ⬆️
...c/Agent/NewRelic/Agent/Core/Metrics/MetricNames.cs 92.15% <100.00%> (+0.28%) ⬆️
...nt/NewRelic/Agent/Core/Samplers/GCSamplerModern.cs 100.00% <100.00%> (ø)
...rc/Agent/NewRelic/Agent/Core/Samplers/GcSampler.cs 82.32% <ø> (+2.02%) ⬆️
.../NewRelic/Agent/Core/Samplers/ImmutableGCSample.cs 100.00% <100.00%> (ø)
...ent/Core/Transformers/GCSampleTransformerModern.cs 100.00% <100.00%> (ø)
....Agent.Extensions/Reflection/VisibilityBypasser.cs 81.26% <82.60%> (+0.07%) ⬆️
... and 1 more

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants