feat: Custom instrumentation supportability metrics #2797
Conversation
| private const string SupportabilityCustomInstrumentationPs = SupportabilityPs + "CustomInst" + PathSeparator; | ||
| public static string GetSupportabilityCustomInstrumentation(string assemblyName, string className, string method) | ||
| { | ||
| return SupportabilityCustomInstrumentationPs + assemblyName + PathSeparator + className + PathSeparator + method; |
There was a problem hiding this comment.
I assume this is what you were referring to when you mentioned the metric name is quite long? I wonder if we have an upper limit on the length of metric names? I don't have any good suggesions, though, for how you could make this any shorter and yet still be descriptive.
There was a problem hiding this comment.
Exactly, here's one from our integration tests: Supportability/CustomInst/DistributedTracingApiApplication/NewRelic.Agent.IntegrationTests.Applications.DistributedTracingApiApplication.Program/CallInsertDTHeaders
I think having the full class name would help with identifying things we want to instrument, but they are quite long. The spec says the limit is 255 bytes for a single metric, and 1MB for the payload. Most customers should only have a few custom instrumentation points (or usually none), so maybe it's ok.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2797 +/- ##
==========================================
+ Coverage 81.21% 81.27% +0.06%
==========================================
Files 460 460
Lines 29219 29249 +30
Branches 3223 3225 +2
==========================================
+ Hits 23731 23773 +42
+ Misses 4701 4692 -9
+ Partials 787 784 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
No description provided.