Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve common library support #106

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dbudziwojskiNR
Copy link
Contributor

@dbudziwojskiNR dbudziwojskiNR commented Oct 18, 2024

Description

Adds several common library configuration options.

Also fixes: #99

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.81%. Comparing base (94bd724) to head (d885b2c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   62.09%   60.81%   -1.28%     
==========================================
  Files          22       22              
  Lines        1224     1475     +251     
==========================================
+ Hits          760      897     +137     
- Misses        392      506     +114     
  Partials       72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbudziwojskiNR dbudziwojskiNR marked this pull request as ready for review October 18, 2024 02:24
@dbudziwojskiNR dbudziwojskiNR requested a review from a team as a code owner October 18, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart priorityClassName is not available
2 participants