Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[newrelic-logging] Fix env var order #1479

Closed
wants to merge 1 commit into from

Conversation

mickutz
Copy link

@mickutz mickutz commented Sep 19, 2024

Is this a new chart

No.

What this PR does / why we need it:

The logging chart is broken as of version newrelic-logging 1.21.0 , where this change was introduced.
The consequence from that change is that when mode: persistentVolume is being used, the FB_DB variable does not get properly resolved as the NODE_NAME variable is only defined further down the list.
From k8s docs:

Note that order matters in the env list. An environment variable is not considered "defined" if it is specified further down the list. 

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [mychartname])

@mickutz mickutz requested a review from a team as a code owner September 19, 2024 10:30
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mickutz
Copy link
Author

mickutz commented Oct 31, 2024

this was a duplicate PR
fixed by #1441

@mickutz mickutz closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[newrelic-logging] BREAKING Bug in env values order
2 participants