[synthetics-job-manager] Update docs in response to GTSE. #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ticket: https://new-relic.atlassian.net/jira/software/c/projects/NR/boards/500?selectedIssue=NR-170132 In response to the above GTSE, I am updating the README here to have the (Not yet configurable) note next to replica count. This is necessary to avoid confusion of a customer trying to change the replica count when we have not added support for that yet.
sidnaiknewrelic
changed the title
sidnaiknewrelic
changed the title
| @@ -53,7 +53,7 @@ This chart will deploy the New Relic Synthetics Containerized Private Job Manage | |||
|
|
|||
| | Parameter | Description | Default | | |||
| |---------------------------------------------|------------------------------------------------------------------------------------------------------|------------------------------------| | |||
| | `ping-runtime.replicaCount` | Number of ping-runtime replicas to maintain | `1` | | |||
| | `ping-runtime.replicaCount` | *(Not yet configurable)* Number of ping-runtime replicas to maintain | `1` | | |||
kondracek-nr
previously approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart
No.
What this PR does / why we need it:
ticket: https://new-relic.atlassian.net/jira/software/c/projects/NR/boards/500?selectedIssue=NR-170132
In response to the above GTSE, I am updating the README here to have the (Not yet configurable) note next to replica count. This is necessary to avoid confusion of a customer trying to change the replica count when we have not added support for that yet.
The note can also be changed to (Not configurable yet) or (Not supported yet). I left this choice up to the reviewer though, if they think that sounds better.
Special notes for your reviewer:
GTSE ticket should have the details for the issue.
Checklist
[mychartname])