Skip to content

Commit

Permalink
fix: Change single quotes to allow to allow interpolation (#1161)
Browse files Browse the repository at this point in the history
<!--
Thank you for contributing to New Relic's Helm charts. Before you submit
this PR we'd like to
make sure you are aware of our technical requirements:

*
https://github.com/newrelic-experimental/helm-charts/blob/master/CONTRIBUTING.md#technical-requirements

For a quick overview across what we will look at reviewing your PR,
please read
our review guidelines:

*
https://github.com/newrelic-experimental/helm-charts/blob/master/REVIEW_GUIDELINES.md

Following our best practices right from the start will accelerate the
review process and
help get your PR merged quicker.

When updates to your PR are requested, please add new commits and do not
squash the
history. This will make it easier to identify new changes. The PR will
be squashed
anyways when it is merged. Thanks.

For fast feedback, please @-mention maintainers that are listed in the
Chart.yaml file.

Please make sure you test your changes before you push them. Once
pushed, a Github Action
will run across your changes and do some initial checks and linting.
These checks run
very quickly. Please check the results. We would like these checks to
pass before we
even continue reviewing your changes.
-->
#### Is this a new chart

#### What this PR does / why we need it:

#### Which issue this PR fixes
*(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)`
format, will close that issue when PR gets merged)*
  - fixes #

#### Special notes for your reviewer:

#### Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove
unrelated fields.]
- [ ] Chart Version bumped
- [ ] Variables are documented in the README.md
- [ ] Title of the PR starts with chart name (e.g. `[mychartname]`)
  • Loading branch information
juanjjaramillo authored Oct 15, 2023
1 parent 7221d17 commit 9298b70
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 17 deletions.
34 changes: 18 additions & 16 deletions .github/workflows/post-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ jobs:
if: startsWith(github.event.release.tag_name, 'nri-bundle-')
name: Update public docs
runs-on: ubuntu-latest
env:
K8S_FOLDER: src/content/docs/release-notes/infrastructure-release-notes/kubernetes-integration-release-notes
steps:
- name: Checkout `nri-kubernetes` chart
uses: actions/checkout@v4
Expand All @@ -94,18 +96,18 @@ jobs:
run: |
today=$(date "+%Y-%m-%d")
{
echo 'release_notes<<EOF'
echo '---'
echo 'subject: Kubernetes integration'
echo "release_notes<<EOF"
echo "---"
echo "subject: Kubernetes integration"
echo "releaseDate: '${today}'"
echo 'version: ${appVersion}'
echo '---'
echo ''
echo 'For a detailed description of changes, see the [release notes](https://github.com/newrelic/nri-kubernetes/releases/tag/v${appVersion}).'
echo ''
echo 'This integration is included in the following chart versions:'
echo '* [newrelic-infrastructure-${version}](https://github.com/newrelic/nri-kubernetes/releases/tag/newrelic-infrastructure-${version}) chart'
echo '* [github.event.release.tag_name](https://github.com/newrelic/helm-charts/releases/tag/${{ github.event.release.tag_name }})'
echo "version: ${appVersion}"
echo "---"
echo ""
echo "For a detailed description of changes, see the [release notes](https://github.com/newrelic/nri-kubernetes/releases/tag/v${appVersion})."
echo ""
echo "This integration is included in the following chart versions:"
echo "* [newrelic-infrastructure-${version}](https://github.com/newrelic/nri-kubernetes/releases/tag/newrelic-infrastructure-${version}) chart"
echo "* [${{ github.event.release.tag_name }}](https://github.com/newrelic/helm-charts/releases/tag/${{ github.event.release.tag_name }})"
echo EOF
} >> "$GITHUB_ENV"
Expand All @@ -114,7 +116,7 @@ jobs:
with:
repository: 'newrelic/docs-website'
sparse-checkout: |
docs-website/src/content/docs/release-notes/infrastructure-release-notes/kubernetes-integration-release-notes
${{ env.K8S_FOLDER }}
sparse-checkout-cone-mode: false

- name: Configure Git
Expand All @@ -126,9 +128,9 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
cd docs-website/src/content/docs/release-notes/infrastructure-release-notes/kubernetes-integration-release-notes
cd ${{ env.K8S_FOLDER }}
appVersionModified=$(echo ${appVersion} | sed 's/\./-/g' )
branchName=add_kubernetes_release_notes-${{ github.sha }}
branchName=add_kubernetes_release_notes-$( date "+%Y-%m-%d_%H_%M" )
releaseFile=kubernetes-integration-${appVersionModified}.mdx
summary="Add release notes for Kubernetes integration v${appVersion}"
Expand All @@ -146,8 +148,8 @@ jobs:
gh pr create \
--base main \
--head ${branchName} \
--title 'feat: ${summary}' \
--body '${summary}'
--title "feat: ${summary}" \
--body "${summary}"
fi
# update-eks-sleek:
Expand Down
2 changes: 1 addition & 1 deletion charts/nri-bundle/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ sources:
- https://github.com/newrelic/helm-charts/tree/master/charts/newrelic-pixie
- https://github.com/newrelic/newrelic-infra-operator/tree/master/charts/newrelic-infra-operator

version: 5.0.33
version: 5.0.34

dependencies:
- name: newrelic-infrastructure
Expand Down

0 comments on commit 9298b70

Please sign in to comment.