Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slack auth and queries #18906

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

amaor-newrelic
Copy link
Contributor

Please follow conventional commit standards
in your commit messages and pull request title.

Give us some context

  • What problems does this PR solve?
  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.
  • If your issue relates to an existing GitHub issue, please link to it.

Copy link

github-actions bot commented Oct 9, 2024

Hi @amaor-newrelic 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 65f01a3
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/6706c110de7a920008fdd6ad
😎 Deploy Preview https://deploy-preview-18906--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Two things happen when authenticating for the first time.
1. OAuth handshake which creates a token for authenticating with Slack
2. The user's personal token is saved (which allows creating a channel to a private slack channel)
This means that even if the original user is removed from the slack workspace, the destination continues to send notifications.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw in the preview that my newline is not actually creating a new line. do i need to add \n? another tag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this doesn't need to be a callout, its bigger than the image before it 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look!

@akristen akristen added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Oct 9, 2024
@akristen
Copy link
Contributor

akristen commented Oct 9, 2024

I've pushed up a commit to modify the slack call out. I'm also reaching out to our eng team for their advice on the i18n files!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants