Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nr-309883 migrate from opensource newrelic #18902

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

ubanerjeeNR
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Oct 9, 2024

Hi @ubanerjeeNR 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

@ubanerjeeNR ubanerjeeNR self-assigned this Oct 9, 2024
Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 3216855
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/6708cbff89496100080b1fe7
😎 Deploy Preview https://deploy-preview-18902--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Oct 9, 2024

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

@ubanerjeeNR ubanerjeeNR added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

@@ -0,0 +1,35 @@
---
title: New Relic Open Source Community Code of Conduct - Reporting Guide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ubanerjeeNR We use sentence case even in titles (https://docs.newrelic.com/docs/style-guide/capitalization/capitalization/#heading_caps)

I think this should be: "New Relic open source community code of conduct - reporting guide"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -0,0 +1,35 @@
---
title: New Relic Open Source Community Code of Conduct - Reporting Guide
metaDescription: Learn how to report violations of the New Relic code of conduct for open source community.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a habit, I usually put quotation marks around the title and metadescription fields, because characters like apostrophes can break the build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

- Your contact info (so we can get in touch with you if we need to follow up).
- Names (real, nicknames, or pseudonyms) of any individuals involved. If there were other witnesses besides you, please try to include them as well.
- When and where the incident occurred. Please be as specific as possible.
- Your account of what occurred. If there is a publicly available record (e.g., a mailing list archive or Slack history) please include a link.
Copy link
Contributor

@paperclypse paperclypse Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But... license docs are where we make exceptions to a lot of these little rules :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad - fixed it.

freshnessValidatedDate: never
---

We believe in the power of Open Source to bring together developers and ideas to solve tricky problems and create the innovative software the world needs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Open Source" should be "open source"

We respect all people in our community, regardless of their background or the extent of their contributions, and encourage participation from diverse sources. This Code of Conduct documents the principles we encourage in, and expect of, the Open Source community.

- Be friendly and patient.
- Be welcoming.<p/>We strive to be a community that welcomes and supports people of all backgrounds and identities. This includes, but is not limited to, members of any race, ethnicity, culture, national origin, colour, immigration status, social or economic class, educational level, sex, sexual orientation, gender identity and expression, age, size, family status, political belief, religion, and mental and physical ability.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove things like these <p /> tags

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure - why though?


<Collapser
id="one-catalog"
title="New Relic One Catalog"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use the brand "New Relic One" anymore. It should just be "New Relic catalog"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

Copy link

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

Copy link

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

Copy link
Contributor

@paperclypse paperclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@ubanerjeeNR ubanerjeeNR merged commit d28651a into develop Oct 11, 2024
16 of 17 checks passed
@ubanerjeeNR ubanerjeeNR deleted the NR-309883-migrate-from-opensource-newrelic branch October 11, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants