Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Azure: Update Azure installation workflow to include containerized apps. #18894

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

jaffinito
Copy link
Member

@jaffinito jaffinito commented Oct 8, 2024

Give us some context

Updates the Azure installation workflow to include containerized apps. Also changes some of the labels and names to better match modern App Service naming as well make things a bit clearer (I hope!).

  • Adds install entries for Windows and Linux containers under Azure App Services
    • Includes modified dockerfiles that do not include app name or license key - these should be set in Azure
    • Includes a step after the dockerfiles covering how to set the license key and app name
  • Renames a few buttons to make them a bit clearer
  • Moves top level NuGet install button to be first for more visibility *

Copy link

github-actions bot commented Oct 8, 2024

Hi @jaffinito 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 1a05828
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/670814b3cf89ed00086db405
😎 Deploy Preview https://deploy-preview-18894--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@akristen akristen self-assigned this Oct 8, 2024
@akristen akristen added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Oct 8, 2024
@akristen
Copy link
Contributor

akristen commented Oct 8, 2024

Hi @jaffinito ! I see this is a draft -- please reach out to the hero when this is complete, and we can get this reviewed for you. This looks like it might be a hefty PR, though. Should I add it to our next docs sprint, which starts next Monday?

@akristen akristen removed their assignment Oct 8, 2024
@jaffinito
Copy link
Member Author

Hi @akristen yes, I think it should be ready by Monday.

@jaffinito jaffinito marked this pull request as ready for review October 10, 2024 19:43
@akristen akristen changed the title chore: Update Azure installation workflow to include containerized apps. .NET Azure: Update Azure installation workflow to include containerized apps. Oct 10, 2024
@akristen akristen self-assigned this Oct 10, 2024
Copy link
Contributor

@akristen akristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akristen akristen merged commit 9ea5d2b into newrelic:develop Oct 15, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants